Skip to content

Commit 833a680

Browse files
gitcommit90claude
andauthored
fix(phase4): use bundled node for Windows version probe (#83)
The Windows acceptance lane installs and runs 1Helm successfully, but its version assertion called bare node even though the Linux host contract keeps Node at /opt/1helm/node-current/bin/node. Use that stable bundled path and lock it into the Phase 4 regression contract. Co-authored-by: Joseph Yaksich <gitcommit90@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
1 parent f6f58a4 commit 833a680

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

ops/platform-acceptance/windows.ps1

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,12 @@ function Assert-DistroVersion([string] $ExpectedVersion) {
5252
# which ended the PowerShell string and executed `systemctl` on Windows.
5353
# Substitute only the already-validated semver after constructing the exact
5454
# bash command, so every service/version assertion really runs inside WSL.
55+
# 1Helm bundles its own Node at the installed /opt/1helm/node-current
56+
# contract path; there is no global `node` on the distro PATH, so invoke
57+
# the bundled binary by absolute path.
5558
$command = @'
5659
test "$(systemctl is-active 1helm.service)" = active
57-
test "$(node -p 'require("/opt/1helm/current/package.json").version')" = '__EXPECTED__'
60+
test "$(/opt/1helm/node-current/bin/node -p 'require("/opt/1helm/current/package.json").version')" = '__EXPECTED__'
5861
'@
5962
Invoke-Distro ($command.Replace('__EXPECTED__', $ExpectedVersion))
6063
}

test/phase4-platform-acceptance.mjs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -212,6 +212,7 @@ test("Windows code publishes no artifact/signing claim and requires honest reboo
212212
assert.match(windows, /apply-linux-release\.sh/);
213213
assert.match(windows, /function Assert-DistroVersion/);
214214
assert.equal((windows.match(/Assert-DistroVersion \$(?:Version|PreviousVersion)/g) || []).length, 4);
215+
assert.match(windows, /\/opt\/1helm\/node-current\/bin\/node/);
215216
assert.match(windows, /UTF8Encoding\(\$false\)/);
216217
assert.match(windows, /\[IO\.File\]::WriteAllText/);
217218
assert.match(windows, /\/bin\/bash -lc "bash '\$scriptInDistro'"/);

0 commit comments

Comments
 (0)