[terminal-stylist] Terminal Stylist: Console Output Analysis (Lipgloss/Huh)

[github-actions[bot]]

Terminal Stylist Report — Console Output Analysis

Scope: 8 non-test .go files using fmt.Print*; codebase-wide scan for lipgloss/huh patterns in pkg/.

Summary

The codebase has a mature, centralized styling infrastructure in pkg/console and pkg/styles, and console output is largely consistent. Findings below are minor polish opportunities, not systemic problems.

✅ What's Working Well

• Centralized theme (pkg/styles/theme.go, pkg/styles/huh_theme.go): adaptive light/dark colors via lipgloss.AdaptiveColor, well-documented semantic palette (Error/Warning/Success/Info).
• TTY-aware rendering: pkg/console/console.go gates all styling through applyStyle/applyStdoutStyleWithTTY, downgrading ANSI via colorwriter.Degrade and honoring NO_COLOR/COLORTERM/TERM. No unguarded raw ANSI escapes found outside pkg/console/terminal.go (cursor/clear-line control codes, which are appropriately low-level) and pkg/stringutil/ansi.go (an ANSI-stripping utility).
• Message-type consistency: pkg/console/print.go exposes PrintSuccessMessage, PrintInfoMessage, PrintWarningMessage, PrintErrorMessage, PrintCommandMessage, PrintSectionHeader — a clean, uniform API used throughout pkg/cli.
• No hardcoded hex colors found outside pkg/styles/theme.go — all consumers use semantic style constants (e.g., styles.Error, styles.ColorInfo), which is exactly right.
• Table rendering centralized via lipgloss/v2/table in pkg/console/console.go only — no ad-hoc manual table formatting found elsewhere.
• Accessibility mode: pkg/console/accessibility.go (IsAccessibleMode) checks ACCESSIBLE, TERM=dumb, and NO_COLOR, and is wired into huh.Form via WithAccessible(IsAccessibleMode()) in pkg/console/prompt_form.go — forms degrade gracefully for screen readers/non-interactive terminals.
• Huh forms are wrapped through helper constructors (NewForm, NewInputForm, NewSelectForm, NewConfirmForm in pkg/console/prompt_form.go), each auto-applying styles.HuhTheme and accessibility — a good pattern preventing inconsistent ad-hoc huh.NewForm(...) calls. Confirmed consumers (pkg/cli/run_interactive.go, add_interactive_*.go, bootstrap_profile_*.go, interactive.go, engine_secrets.go) rely on these wrappers rather than raw huh calls.
• User-abort handling centralized via IsUserAbortedError (wraps huh.ErrUserAborted), avoiding duplicated error-string checks across interactive flows.

🔍 Minor Observations (fmt.Print usage)

Two non-test files use fmt.Print directly instead of fmt.Fprint*(os.Stdout, ...)/console helpers:

1. pkg/cli/status_command.go:295 — fmt.Print(console.RenderStruct(statuses))
   Already delegates styling to console.RenderStruct; only the print call itself is raw. Low-risk, but for consistency with the surrounding code in the same function (which uses fmt.Fprintln(os.Stdout, ...) and fmt.Fprintln(os.Stderr, ...) a few lines above), consider fmt.Fprint(os.Stdout, console.RenderStruct(statuses)) for uniform stream targeting.

2. pkg/cli/view_command.go:168 — fmt.Print(output) where output := renderUnifiedTimelineStream(events).
   Same pattern: styled content already built via console helpers; only the final print bypasses explicit os.Stdout targeting. Same minor suggestion applies.

All other fmt.Print* matches are in linter test fixtures (testdata/) or doc comments — not applicable.

Recommendations

Priority	Item	Suggestion
Low	status_command.go:295, view_command.go:168	Switch bare fmt.Print to fmt.Fprint(os.Stdout, ...) for explicit stream targeting, matching sibling calls in the same functions. Purely stylistic — current behavior is correct since both already target stdout by default.
Info	Huh forms	Current wrapper pattern (NewForm/NewInputForm/etc.) is a best practice — continue routing all new interactive prompts through pkg/console/prompt_form.go rather than calling huh.NewForm directly, to keep theme + accessibility guarantees automatic.
Info	Lipgloss	No action needed — adaptive colors, TTY detection, and table styling are already centralized and consistently applied.

Conclusion

No significant anti-patterns found. The pkg/console + pkg/styles layering is a strong foundation that new code already follows. Only two trivial fmt.Print → fmt.Fprint(os.Stdout, ...) cleanups are suggested for full consistency; neither affects behavior or accessibility.

Generated by 💄 Terminal Stylist · auto · 22.8 AIC · ⌖ 6.24 AIC · ⊞ 8.3K · ◷

• expires on Aug 24, 2026, 12:53 AM UTC-08:00

[github-actions[bot]]

This discussion was automatically closed because it expired on 2026-08-24T08:53:41.741Z.

Closed by Workflow