From 1da7acfa706752ad0970c0f37cf52f51f5b83009 Mon Sep 17 00:00:00 2001 From: fredbi <14262513+fredbi@users.noreply.github.com> Date: Tue, 17 Nov 2026 17:52:50 +0000 Subject: [PATCH] Fix: Set should return error instead of panicking when passed a pointer to a nil map. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * fixes #163 Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Signed-off-by: Frédéric BIDON --- pointer.go | 5 +++++ pointer_test.go | 20 ++++++++++++++++++++ 2 files changed, 25 insertions(+) diff --git a/pointer.go b/pointer.go index d17fa19..03ebd44 100644 --- a/pointer.go +++ b/pointer.go @@ -694,6 +694,11 @@ func setSingleImpl(node, data any, decodedToken string, nameProvider NameProvide return node, nil case reflect.Map: + if rValue.IsNil() { + // a pointer to a nil map: assigning to it would panic + return node, fmt.Errorf("cannot set field %q on nil value: %w", decodedToken, ErrPointer) + } + kv, err := mapKeyValue(rValue.Type(), decodedToken) if err != nil { return node, err diff --git a/pointer_test.go b/pointer_test.go index 0f73065..6494dc8 100644 --- a/pointer_test.go +++ b/pointer_test.go @@ -1501,3 +1501,23 @@ func TestSetMapValues(t *testing.T) { require.Nil(t, value) }) } + +func TestSetPointerToNilMap(t *testing.T) { + t.Parallel() + + p, err := New("/key") + require.NoError(t, err) + + var document map[string]any + + require.NotPanics(t, func() { + _, err = p.Set(&document, 1) + }) + require.Error(t, err) + require.ErrorIs(t, err, ErrPointer) + + require.NotPanics(t, func() { + _, err = SetForToken(&document, "key", 1) + }) + require.Error(t, err) +}