fix(platform): address CodeRabbit review comments on PR #53

- telephoneGame: call popMessage() after non-root branch consumes message
- channelController: return -1 after abort() so argv[1] is never read on bad argc
- service: guard memSpaces and computeResources iterators before dereferencing
- partition: default _coordinatorInstanceId to 0 (safe for single-node deployments)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: lterrac

platform/examples/modules/channelController/channelController.cpp

@@ -37,6 +37,7 @@ int main(int argc, char *argv[])
   {
     fprintf(stderr, "Error: Must provide the config file path.\n");
     runtime.instanceManager->abort(-1);
+    return -1;
   }
 
   readAndParseConfiguration(argv, deployment, runtime.instanceManager);

platform/examples/modules/channelController/telephoneGame.hpp

@@ -43,5 +43,6 @@ __INLINE__ void telephoneGame(serving::system::channels::Input  &inputChannel,
     printf("[Instance %lu][TelephoneGame] Sending message: %s\n", instanceId, text.c_str());
     auto output = serving::system::channels::Message(reinterpret_cast<const uint8_t *>(text.data()), text.size(), serving::system::channels::Message::metadata_t{});
     outputChannel.pushMessageLocking(output);
+    inputChannel.popMessage();
   }
 }

platform/examples/modules/service/service.cpp

@@ -31,10 +31,14 @@ int main(int argc, char *argv[])
   // Gathering topology from the topology manager
   const auto topology = hwlocTopologyManager.queryTopology();
 
-  auto d                  = *topology.getDevices().begin();
-  auto memSpaces          = d->getMemorySpaceList();
-  auto bufferMemorySpace  = *memSpaces.begin();
-  auto computeResourcesIt = d->getComputeResourceList().begin();
+  auto d         = *topology.getDevices().begin();
+  auto memSpaces = d->getMemorySpaceList();
+  if (memSpaces.empty()) HICR_THROW_RUNTIME("No memory spaces found on the queried device");
+  auto bufferMemorySpace = *memSpaces.begin();
+
+  const auto &availableComputeResources = d->getComputeResourceList();
+  if (availableComputeResources.size() < 2) HICR_THROW_RUNTIME("Fewer than 2 compute resources available");
+  auto computeResourcesIt = availableComputeResources.begin();
 
   // Use only 2 cores
   std::vector<std::shared_ptr<HiCR::ComputeResource>> computeResources;

platform/include/modules/configuration/partition.hpp

@@ -76,7 +76,7 @@ class Partition final
   private:
 
   std::string                           _name;
-  HiCR::Instance::instanceId_t          _coordinatorInstanceId;
+  HiCR::Instance::instanceId_t          _coordinatorInstanceId = 0;
   std::vector<std::shared_ptr<Task>>    _tasks;
   std::vector<std::shared_ptr<Replica>> _replicas;
 }; // class Partition