Merge pull request #518 from hypervel/revert/server-reloader

Revert provider-based server reloading

Author: binaryfire

docs/plans/2026-08-08-1956-server-reloader-and-worker-configuration-refresh.md

@@ -22,6 +22,7 @@
 
 - Convert the remaining tests that extend `PHPUnit\Framework\TestCase` to `Hypervel\Tests\TestCase` as required by `AGENTS.md`, verifying each file individually under coroutine execution and opting out only when the test explicitly exercises coroutine transitions.
 - Design a connection-owned service identity and capability API for external backends that packages can query without repeated hot-path probes. Redis/Valkey and database connections already expose fragments of this information in different forms; prefer lazy detection cached for the current connection or pool generation, with invalidation on reconnect and purge, over an eager process-global startup registry that performs unused I/O or survives a backend change. Start with concrete consumers and capability checks rather than a universal version-comparison abstraction.
+- Find a clean, simple framework-wide solution for configuration-dependent services resolved before worker configuration reload. `server:reload` refreshes the existing configuration repository, but objects that have already copied configuration into their own state remain stale. For example, `SentryServiceProvider` eagerly resolves a worker-lifetime Hub and client during boot, so DSN, environment, and sampling changes are not applied until a full restart; resolving `Cache::store('some-store')` from a service provider populates `CacheManager`'s store cache before reload, so changes to that store's driver, connection, prefix, or other captured configuration are likewise not applied. Define the reload contract, audit framework-owned eager resolutions and manager caches, and solve the lifecycle at their shared owning boundary instead of adding package-specific refresh hooks or application workarounds.
 - Investigate where requiring and directly using a PHP extension would make framework code significantly faster than its current pure-PHP implementation. The framework already declares bundled extensions it depends on, so the question is which hot paths are doing in PHP what a C extension does natively. The worked example is `ext-gmp` for identifier encoding: UUID and ULID string conversion and any base32/base58/base62 short-id work exceed 64 bits, so `ramsey/uuid` and `symfony/uid` convert them digit by digit in PHP, while `gmp_init()`/`gmp_strval()` do arbitrary-base conversion natively — a hand-rolled base-36 UUID conversion measured 14.6 µs against 0.5 µs for the GMP equivalent with byte-identical output. Anything that fits in a 64-bit int (snowflakes, timestamps, counters) needs no extension, and hashing, encryption, and signatures are already C. Measure `Str::uuid()`/`Str::ulid()` and the other candidates before adding a requirement, and weigh each new extension against installation cost.
 - Convert untyped `$config->get()` calls across `src/` to the typed getters (`string()`, `integer()`, `float()`, `boolean()`, `array()`) without call-site defaults, for every key that isn't genuinely nullable. Defaults live in the merged config files — declare any key currently defaulted only at a call site in its package's config file as part of the conversion. Typed getters throw `InvalidArgumentException` naming the key on misconfiguration instead of letting a wrong type propagate silently, and give phpstan real return types. Bootstrap code that runs before config merging keeps its call-site defaults. Approved modernization per the Porting Packages policy in `AGENTS.md`; new code already follows the rule.
 - Audit unmatched PHPStan inline ignores and global patterns with `reportUnmatchedIgnoredErrors` enabled — currently 196 unmatched inline ignores across 99 files plus 5 unmatched global patterns. Remove only suppressions that no longer match after tracing the underlying code; do not replace correct source with runtime branches or wider types merely to keep static analysis green. Decide as part of the work whether `phpstan.neon.dist` should then set `reportUnmatchedIgnoredErrors: true` permanently, since leaving it `false` lets the suppressions rot again.

docs/plans/2026-08-20-1310-revert-provider-based-server-reloader.md

@@ -11,7 +11,6 @@
 use Hypervel\Contracts\Auth\Access\Gate as GateContract;
 use Hypervel\Contracts\Auth\Authenticatable as AuthenticatableContract;
 use Hypervel\Contracts\Config\Repository as ConfigRepository;
-use Hypervel\Contracts\Foundation\ReloadsConfiguration;
 use Hypervel\Core\Events\AfterWorkerStart;
 use Hypervel\Database\Eloquent\Builder as EloquentBuilder;
 use Hypervel\Database\Eloquent\Collection as EloquentCollection;
@@ -26,7 +25,7 @@
 
 use function Hypervel\Support\enum_value;
 
-class AuthServiceProvider extends ServiceProvider implements ReloadsConfiguration
+class AuthServiceProvider extends ServiceProvider
 {
     private const int MAX_QUERY_ATTRIBUTE_LENGTH = 63;
 
@@ -43,19 +42,6 @@ public function register(): void
         $this->commands([ClearResetsCommand::class]);
     }
 
-    /**
-     * Reload configuration-derived worker state.
-     *
-     * Boot-only. Request-time use clears shared resolved guards while
-     * concurrent coroutines may still be using them.
-     */
-    public function reloadConfiguration(): void
-    {
-        if ($this->app->resolved('auth')) {
-            $this->app->make('auth')->forgetGuards();
-        }
-    }
-
     /**
      * Bootstrap the service provider.
      */

docs/todo.md

@@ -188,19 +188,6 @@ public function setDefaultDriver(UnitEnum|string $name): void
         CoroutineContext::set(self::DEFAULT_BROKER_CONTEXT_KEY, $name);
     }
 
-    /**
-     * Forget all resolved password brokers.
-     *
-     * Boot or tests only. Mutates the singleton's broker cache; concurrent
-     * coroutines may already hold a broker that next resolution will replace.
-     */
-    public function forgetBrokers(): static
-    {
-        $this->brokers = [];
-
-        return $this;
-    }
-
     /**
      * Refresh the event dispatcher on resolved brokers.
      *

src/auth/src/AuthServiceProvider.php

@@ -4,10 +4,9 @@
 
 namespace Hypervel\Auth\Passwords;
 
-use Hypervel\Contracts\Foundation\ReloadsConfiguration;
 use Hypervel\Support\ServiceProvider;
 
-class PasswordResetServiceProvider extends ServiceProvider implements ReloadsConfiguration
+class PasswordResetServiceProvider extends ServiceProvider
 {
     /**
      * Register the service provider.
@@ -18,19 +17,6 @@ public function register(): void
         $this->registerEventRebindHandler();
     }
 
-    /**
-     * Reload configuration-derived worker state.
-     *
-     * Boot-only. Request-time use clears shared resolved brokers while
-     * concurrent coroutines may still be using them.
-     */
-    public function reloadConfiguration(): void
-    {
-        if ($this->app->resolved('auth.password')) {
-            $this->app->make('auth.password')->forgetBrokers();
-        }
-    }
-
     /**
      * Register the password broker instance.
      */

src/auth/src/Passwords/PasswordBrokerManager.php

@@ -6,10 +6,9 @@
 
 use Hypervel\Contracts\Broadcasting\Broadcaster as BroadcasterContract;
 use Hypervel\Contracts\Broadcasting\Factory as BroadcastingFactory;
-use Hypervel\Contracts\Foundation\ReloadsConfiguration;
 use Hypervel\Support\ServiceProvider;
 
-class BroadcastServiceProvider extends ServiceProvider implements ReloadsConfiguration
+class BroadcastServiceProvider extends ServiceProvider
 {
     /**
      * Register the service provider.
@@ -25,19 +24,4 @@ public function register(): void
             BroadcastingFactory::class
         );
     }
-
-    /**
-     * Reload configuration-derived worker state.
-     *
-     * Boot-only. Request-time use clears shared broadcast connections while
-     * concurrent coroutines may still be using them.
-     */
-    public function reloadConfiguration(): void
-    {
-        if ($this->app->resolved(BroadcastManager::class)) {
-            $this->app->make(BroadcastManager::class)->forgetDrivers();
-        }
-
-        $this->app->forgetInstance(BroadcasterContract::class);
-    }
 }

src/auth/src/Passwords/PasswordResetServiceProvider.php

@@ -7,11 +7,10 @@
 use Hypervel\Container\Container;
 use Hypervel\Contracts\Bus\Dispatcher as DispatcherContract;
 use Hypervel\Contracts\Bus\QueueingDispatcher as QueueingDispatcherContract;
-use Hypervel\Contracts\Foundation\ReloadsConfiguration;
 use Hypervel\Contracts\Queue\Factory as QueueFactoryContract;
 use Hypervel\Support\ServiceProvider;
 
-class BusServiceProvider extends ServiceProvider implements ReloadsConfiguration
+class BusServiceProvider extends ServiceProvider
 {
     /**
      * Register the service provider.
@@ -37,18 +36,6 @@ public function register(): void
         );
     }
 
-    /**
-     * Reload configuration-derived worker state.
-     *
-     * Boot-only. Request-time use replaces shared batch repositories while
-     * concurrent coroutines may still hold the previous instances.
-     */
-    public function reloadConfiguration(): void
-    {
-        $this->app->forgetInstance(BatchRepository::class);
-        $this->app->forgetInstance(DatabaseBatchRepository::class);
-    }
-
     /**
      * Register the batch handling services.
      */

src/broadcasting/src/BroadcastServiceProvider.php

@@ -471,19 +471,6 @@ public function forgetDriver(array|UnitEnum|string|null $name = null): static
         return $this;
     }
 
-    /**
-     * Forget all resolved cache drivers.
-     *
-     * Boot or tests only. Mutates the singleton's store cache; concurrent
-     * coroutines may already hold stores that next resolution will replace.
-     */
-    public function forgetDrivers(): static
-    {
-        $this->stores = [];
-
-        return $this;
-    }
-
     /**
      * Disconnect the given driver and remove from local cache.
      *
@@ -540,10 +527,9 @@ public function setApplication(Container $app): static
      * Register classes that cache stores may unserialize.
      *
      * Boot-only. The resolver contributes to the worker-lifetime cache policy
-     * and is evaluated after every provider has booted: at application boot
-     * completion in console processes or after configuration reload in each
-     * Swoole worker. An earlier cache read evaluates the current contributions
-     * without memoizing them.
+     * and is evaluated at application boot completion in console processes or
+     * after the worker configuration is rebuilt in Swoole workers. An earlier
+     * cache read evaluates the current contributions without memoizing them.
      *
      * @param Closure(): array<array-key, class-string> $resolver
      *

src/bus/src/BusServiceProvider.php

@@ -13,12 +13,11 @@
 use Hypervel\Cache\Listeners\RegisterSwooleMaintenanceTimers;
 use Hypervel\Cache\Redis\Console\BenchmarkCommand;
 use Hypervel\Cache\Redis\Console\DoctorCommand;
-use Hypervel\Contracts\Foundation\ReloadsConfiguration;
 use Hypervel\Core\Events\AfterWorkerStart;
 use Hypervel\Core\Events\BeforeServerStart;
 use Hypervel\Support\ServiceProvider;
 
-class CacheServiceProvider extends ServiceProvider implements ReloadsConfiguration
+class CacheServiceProvider extends ServiceProvider
 {
     /**
      * Register the service provider.
@@ -40,21 +39,6 @@ public function register(): void
         ]);
     }
 
-    /**
-     * Reload configuration-derived worker state.
-     *
-     * Boot-only. Request-time use clears shared cache stores while concurrent
-     * coroutines may still be using them.
-     */
-    public function reloadConfiguration(): void
-    {
-        if ($this->app->resolved('cache')) {
-            $this->app->make('cache')->forgetDrivers();
-        }
-
-        $this->app->forgetInstance('cache.store');
-    }
-
     /**
      * Bootstrap the service provider.
      */
@@ -80,7 +64,7 @@ public function boot(): void
             return;
         }
 
-        // Worker configuration is reloaded during BeforeWorkerStart.
+        // Finalize after BeforeWorkerStart rebuilds the worker configuration.
         $events->listen(AfterWorkerStart::class, function (AfterWorkerStart $event): void {
             $this->app->make(CacheManager::class)->finalizeSerializableClasses();
         });