Skip to content

FormComponent should use defaultProps #297

Description

@dcocchia

If an id prop is not passed to the FormComponent component, it generates a unique id for labels lower down in the component tree. This is great in some ways, but it has a couple issues:

  • It's not clear in the documentation that this will happen, since it's not using defaultProps
  • This causes issues with snapshot tests for users of the library, since this data is randomized for each test run

Issue 1 has an obvious fix. Issue 2 could just be a requirement for users to supply an id prop during tests.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions