Skip to content

Loader silently fails during unique key lookup #649

Description

@znatty22

The loader is silently failing in this step:

because the key lookup is enclosed in a generic try/except causing it to miss real exceptions.

This recently happened when it tried to create the key for a phenotype using the event age but a ValueError was thrown due to an invalid int conversion. The ValueError was hidden due to the line above and the ingest library user did not know why the phenotype was not loaded.

We should make a custom exception that gets thrown for known error conditions during unique key lookup

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions