Skip to content

Dependency on Magento was sneaked in as part of the Computed Resolver work #90

Description

@pawel-siejba

This package has no declared composer dependencies on Magento, yet in 6d25b49 a dependency is hardcoded.

This means that it cannot be considered anymore as a standalone implementation of upward in PHP.

Following Dependency Inversion principle we should create an interface which \Magento\UpwardConnector\Model\ComputedPool implements, or make \Magento\UpwardConnector\Model\ComputedPool part of the magento/upward-php together with \Magento\UpwardConnector\Api\ComputedInterface.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions