address comments

Author: V-FEXrt

docs/DXIL.rst

@@ -3217,7 +3217,7 @@ INSTR.LINALGMATRIXDIMVECTORMISMATCH                   %0 vector size '%1' must m
 INSTR.LINALGMATRIXLAYOUTREQSTRIDE                     %0 with layout '%1' requires stride 0.
 INSTR.LINALGMATRIXLOADTHREADREQUIRESBAB               Loading matrix with Thread scope requires ByteAddressBuffer.
 INSTR.LINALGMATRIXMATRIXKDIMMUSTMATCH                 K dim of A matrix '%0' must match K dim of B matrix '%1'. %2 != %3.
-INSTR.LINALGMATRIXMATRIXRESDIMMUSTMATCH               %0 matrix dimension '%1' must match A.MxB.N '%2'
+INSTR.LINALGMATRIXMATRIXRESDIMMUSTMATCH               %0 matrix dimension '%1' must match A.MxB.N '%2'.
 INSTR.LINALGMATRIXNOTEXACTMATCH                       %0 matrix '%1' must exactly match %2 matrix '%3'.
 INSTR.LINALGMATRIXOUTPUTBIASVECMISMATCH               Output vector element type '%0' must match bias vector element type '%1'
 INSTR.LINALGMATRIXREQUIRESLAYOUT2                     %0 requires layout %1 or %2.

tools/clang/test/LitDXILValidation/LinAlgMatrix/linalgmatrix-matrixmultiply.ll

@@ -66,7 +66,7 @@ define void @main() {
   ; CHECK-NEXT: note: at {{.*}} @dx.op.linAlgMatrixMultiply.mC8M8N8U2S2.mC8M8N8U0S2.mC8M6N8U1S2
   %18 = call %dx.types.LinAlgMatrixC8M8N8U2S2 @dx.op.linAlgMatrixMultiply.mC8M8N8U2S2.mC8M8N8U0S2.mC8M6N8U1S2(i32 -2147483625, %dx.types.LinAlgMatrixC8M8N8U0S2 %14, %dx.types.LinAlgMatrixC8M6N8U1S2 %11)  ; LinAlgMatrixMultiply(matrixA,matrixB)
 
-  ; CHECK-NEXT: Function: main: error: Return matrix dimension '8x6' must match A.MxB.N '8x8'
+  ; CHECK-NEXT: Function: main: error: Return matrix dimension '8x6' must match A.MxB.N '8x8'.
   ; CHECK-NEXT: note: at {{.*}} @dx.op.linAlgMatrixMultiply.mC8M8N6U2S2.mC8M8N8U0S2.mC8M8N8U1S2
   %19 = call %dx.types.LinAlgMatrixC8M8N6U2S2 @dx.op.linAlgMatrixMultiply.mC8M8N6U2S2.mC8M8N8U0S2.mC8M8N8U1S2(i32 -2147483625, %dx.types.LinAlgMatrixC8M8N8U0S2 %14, %dx.types.LinAlgMatrixC8M8N8U1S2 %5)  ; LinAlgMatrixMultiply(matrixA,matrixB)
 

tools/clang/test/LitDXILValidation/LinAlgMatrix/linalgmatrix-matrixmultiplyaccumulate.ll

@@ -47,7 +47,7 @@ define void @main() {
   ; CHECK-NEXT: note: at {{.*}} @dx.op.linAlgMatrixMultiplyAccumulate.mC8M8N8U2S2.mC8M8N8U0S2.mC8M8N8U0S2.mC8M8N8U2S2
   %20 = call %dx.types.LinAlgMatrixC8M8N8U2S2 @dx.op.linAlgMatrixMultiplyAccumulate.mC8M8N8U2S2.mC8M8N8U0S2.mC8M8N8U0S2.mC8M8N8U2S2(i32 -2147483637, %dx.types.LinAlgMatrixC8M8N8U0S2 %3, %dx.types.LinAlgMatrixC8M8N8U0S2 %3, %dx.types.LinAlgMatrixC8M8N8U2S2 %7)  ; LinAlgMatrixMultiplyAccumulate(matrixA,matrixB,matrixC)
 
-  ; CHECK-NEXT: Function: main: error: C matrix use 'B' does not match expected use Accumulator.
+  ; CHECK-NEXT: Function: main: error: C matrix use 'A' does not match expected use Accumulator.
   ; CHECK-NEXT: note: at {{.*}} @dx.op.linAlgMatrixMultiplyAccumulate.mC8M8N8U2S2.mC8M8N8U0S2.mC8M8N8U1S2.mC8M8N8U0S2
   %21 = call %dx.types.LinAlgMatrixC8M8N8U2S2 @dx.op.linAlgMatrixMultiplyAccumulate.mC8M8N8U2S2.mC8M8N8U0S2.mC8M8N8U1S2.mC8M8N8U0S2(i32 -2147483637, %dx.types.LinAlgMatrixC8M8N8U0S2 %3, %dx.types.LinAlgMatrixC8M8N8U1S2 %5, %dx.types.LinAlgMatrixC8M8N8U0S2 %3)  ; LinAlgMatrixMultiplyAccumulate(matrixA,matrixB,matrixC)
 
@@ -87,11 +87,11 @@ define void @main() {
   ; CHECK-NEXT: note: at {{.*}} @dx.op.linAlgMatrixMultiplyAccumulate.mC8M8N8U2S2.mC8M8N6U0S2.mC8M8N8U1S2.mC8M8N8U2S2
   %27 = call %dx.types.LinAlgMatrixC8M8N8U2S2 @dx.op.linAlgMatrixMultiplyAccumulate.mC8M8N8U2S2.mC8M8N6U0S2.mC8M8N8U1S2.mC8M8N8U2S2(i32 -2147483637, %dx.types.LinAlgMatrixC8M8N6U0S2 %15, %dx.types.LinAlgMatrixC8M8N8U1S2 %22, %dx.types.LinAlgMatrixC8M8N8U2S2 %7)  ; LinAlgMatrixMultiplyAccumulate(matrixA,matrixB,matrixC)
 
-  ; CHECK-NEXT: Function: main: error: C matrix dimension '8x6' must match A.MxB.N '8x8'
+  ; CHECK-NEXT: Function: main: error: C matrix dimension '8x6' must match A.MxB.N '8x8'.
   ; CHECK-NEXT: note: at {{.*}} @dx.op.linAlgMatrixMultiplyAccumulate.mC8M8N8U2S2.mC8M8N8U0S2.mC8M8N8U1S2.mC8M8N6U2S2
   %28 = call %dx.types.LinAlgMatrixC8M8N8U2S2 @dx.op.linAlgMatrixMultiplyAccumulate.mC8M8N8U2S2.mC8M8N8U0S2.mC8M8N8U1S2.mC8M8N6U2S2(i32 -2147483637, %dx.types.LinAlgMatrixC8M8N8U0S2 %3, %dx.types.LinAlgMatrixC8M8N8U1S2 %22, %dx.types.LinAlgMatrixC8M8N6U2S2 %17)  ; LinAlgMatrixMultiplyAccumulate(matrixA,matrixB,matrixC)
 
-  ; CHECK-NEXT: Function: main: error: Return matrix dimension '8x6' must match A.MxB.N '8x8'
+  ; CHECK-NEXT: Function: main: error: Return matrix dimension '8x6' must match A.MxB.N '8x8'.
   ; CHECK-NEXT: note: at {{.*}} @dx.op.linAlgMatrixMultiplyAccumulate.mC8M8N6U2S2.mC8M8N8U0S2.mC8M8N8U1S2.mC8M8N8U2S2
   %29 = call %dx.types.LinAlgMatrixC8M8N6U2S2 @dx.op.linAlgMatrixMultiplyAccumulate.mC8M8N6U2S2.mC8M8N8U0S2.mC8M8N8U1S2.mC8M8N8U2S2(i32 -2147483637, %dx.types.LinAlgMatrixC8M8N8U0S2 %3, %dx.types.LinAlgMatrixC8M8N8U1S2 %22, %dx.types.LinAlgMatrixC8M8N8U2S2 %7)  ; LinAlgMatrixMultiplyAccumulate(matrixA,matrixB,matrixC)
 

utils/hct/hctdb.py

@@ -8727,7 +8727,7 @@ def build_valrules(self):
         )
         self.add_valrule(
             "Instr.LinAlgMatrixMatrixResDimMustMatch",
-            "%0 matrix dimension '%1' must match A.MxB.N '%2'",
+            "%0 matrix dimension '%1' must match A.MxB.N '%2'.",
         )
 
         # Some legacy rules: