Apply suggestions from code review

Co-authored-by: Michael Lueken <63728921+MichaelLueken@users.noreply.github.com>

Author: mkavulich

data_environment.yml

@@ -1,4 +1,4 @@
-name: srw_app
+name: get_data
 channels:
   - conda-forge
   - ufs-community

tests/WE2E/monitor_jobs.py

@@ -17,7 +17,7 @@
                   update_expt_status_parallel, print_WE2E_summary
 
 def monitor_jobs(expts_dict: dict, monitor_file: str = '', procs: int = 1,
-                 mode: str = 'continuous', delay: int = 10, debug: bool = False) -> str:
+                 mode: str = 'continuous', delay: int = 5, debug: bool = False) -> str:
     """Monitors and runs jobs for the specified experiment using Rocoto
 
     Args:
@@ -180,7 +180,7 @@ def setup_logging(logfile: str = "log.run_WE2E_tests", debug: bool = False) -> N
                         help='YAML-format file specifying the information of jobs to be run; '\
                              'for an example file, see monitor_jobs.yaml', required=True)
     parser.add_argument('--delay', type=int,
-                        help='Pause this number of seconds between calls to rocotorun', default=10)
+                        help='Pause this number of seconds between calls to rocotorun', default=5)
     parser.add_argument('-p', '--procs', type=int,
                         help='Run resource-heavy tasks (such as calls to rocotorun) in parallel, '\
                              'with provided number of parallel tasks', default=1)

tests/WE2E/run_we2e_tests.py

@@ -50,7 +50,7 @@ def run_we2e_tests(homedir, args) -> None:
 
     # Derecho requires long delay between calls to rocotorun due to system-level cacheing of
     # job statuses
-    if machine=="DERECHO":
+    if machine=="derecho":
         if args.delay < 60:
             logging.info("Derecho requires 60 second delay between calls to rocotorun")
             args.delay=60