fixup! refactor: continue TS migration

Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>

Author: Chartman123

src/components/Questions/AnswerInput.vue

@@ -107,8 +107,6 @@ import { INPUT_DEBOUNCE_MS, OptionType } from '../../models/Constants.ts'
 import logger from '../../utils/Logger.ts'
 import OcsResponse2Data from '../../utils/OcsResponse2Data.ts'
 
-type AnswerInputOption = FormsOption
-
 export default defineComponent({
 	name: 'AnswerInput',
 
@@ -192,20 +190,20 @@ export default defineComponent({
 			queue: null as PQueue | null,
 			debounceOnInput: undefined as ((event: InputEvent) => void) | undefined,
 			isIMEComposing: false,
-			localText: (this.answer as AnswerInputOption | undefined)?.text ?? '',
+			localText: (this.answer as FormsOption | undefined)?.text ?? '',
 		}
 	},
 
 	computed: {
 		canCreateLocalAnswer(): boolean {
-			if ((this.answer as AnswerInputOption).local) {
+			if ((this.answer as FormsOption).local) {
 				return !!this.localText?.trim()
 			}
-			return !!(this.answer as AnswerInputOption).text?.trim()
+			return !!(this.answer as FormsOption).text?.trim()
 		},
 
 		ariaLabel(): string {
-			const answer = this.answer as AnswerInputOption
+			const answer = this.answer as FormsOption
 			if (answer.local) {
 				if (this.optionType === OptionType.Column) {
 					return t('forms', 'Add a new column')
@@ -235,12 +233,12 @@ export default defineComponent({
 		},
 
 		optionDragMenuId(): string {
-			const answer = this.answer as AnswerInputOption
+			const answer = this.answer as FormsOption
 			return `q${answer.questionId}o${answer.id}o${this.optionType}__drag_menu`
 		},
 
 		placeholder(): string {
-			const answer = this.answer as AnswerInputOption
+			const answer = this.answer as FormsOption
 			if (answer.local) {
 				if (this.optionType === OptionType.Column) {
 					return t('forms', 'Add a new column')
@@ -265,7 +263,7 @@ export default defineComponent({
 		},
 
 		pseudoIcon(): string {
-			const answer = this.answer as AnswerInputOption
+			const answer = this.answer as FormsOption
 			if (answer.local) {
 				return IconPlus
 			}
@@ -289,7 +287,7 @@ export default defineComponent({
 	watch: {
 		// Keep localText in sync when the parent replaces/updates the answer prop
 		answer: {
-			handler(newVal: AnswerInputOption) {
+			handler(newVal: FormsOption) {
 				this.localText = newVal?.text ?? ''
 			},
 
@@ -336,7 +334,7 @@ export default defineComponent({
 				return
 			}
 
-			const answer = this.answer as AnswerInputOption
+			const answer = this.answer as FormsOption
 			if (answer.local) {
 				this.localText = target.value
 				return
@@ -367,7 +365,7 @@ export default defineComponent({
 		 * @param e the keydown event
 		 */
 		onEnter(e: KeyboardEvent): void {
-			if ((this.answer as AnswerInputOption).local) {
+			if ((this.answer as FormsOption).local) {
 				this.createLocalAnswer(e)
 				return
 			}
@@ -392,7 +390,7 @@ export default defineComponent({
 			}
 
 			const answer = {
-				...(this.answer as AnswerInputOption),
+				...(this.answer as FormsOption),
 				text: value,
 				local: false,
 			}
@@ -451,7 +449,7 @@ export default defineComponent({
 				return
 			}
 
-			if ((this.answer as AnswerInputOption).local) {
+			if ((this.answer as FormsOption).local) {
 				return
 			}
 
@@ -469,7 +467,7 @@ export default defineComponent({
 				return
 			}
 			queue.add(() => {
-				this.$emit('delete', this.answer as AnswerInputOption)
+				this.$emit('delete', this.answer as FormsOption)
 				// Prevent any patch requests
 				queue.pause()
 				queue.clear()
@@ -482,7 +480,7 @@ export default defineComponent({
 		 * @param answer the answer to sync
 		 * @return answer
 		 */
-		async createAnswer(answer: AnswerInputOption): Promise<AnswerInputOption> {
+		async createAnswer(answer: FormsOption): Promise<FormsOption> {
 			try {
 				const response = await axios.post(
 					generateOcsUrl(
@@ -501,7 +499,7 @@ export default defineComponent({
 
 				// Was synced once, this is now up to date with the server
 				delete answer.local
-				return (OcsResponse2Data(response) as AnswerInputOption[])[0]
+				return (OcsResponse2Data(response) as FormsOption[])[0]
 			} catch (error) {
 				logger.error('Error while saving answer', { answer, error })
 				showError(t('forms', 'Error while saving the answer'))
@@ -516,7 +514,7 @@ export default defineComponent({
 		 *
 		 * @param answer the answer to sync
 		 */
-		async updateAnswer(answer: AnswerInputOption): Promise<void> {
+		async updateAnswer(answer: FormsOption): Promise<void> {
 			try {
 				await axios.patch(
 					generateOcsUrl(

src/components/Questions/QuestionFile.vue

@@ -211,14 +211,6 @@ type QuestionFileExtraSettings = {
 	maxFileSize?: number
 }
 
-interface QuestionFileData {
-	fileTypes: typeof fileTypes
-	fileLoading: boolean
-	maxFileSizeUnit: FileSizeUnit
-	maxFileSizeValue: number
-	allowedFileTypesDialogOpened: boolean
-}
-
 export default defineComponent({
 	name: 'QuestionFile',
 	components: {
@@ -248,13 +240,13 @@ export default defineComponent({
 		}
 	},
 
-	data(): QuestionFileData {
+	data() {
 		return {
-			fileTypes,
-			fileLoading: false,
+			fileTypes: typeof fileTypes,
+			fileLoading: false as boolean,
 			maxFileSizeUnit: Object.keys(FILE_SIZE_UNITS)[0] as FileSizeUnit,
-			maxFileSizeValue: 0,
-			allowedFileTypesDialogOpened: false,
+			maxFileSizeValue: 0 as number,
+			allowedFileTypesDialogOpened: false as boolean,
 		}
 	},