Skip to content

Commit b402de4

Browse files
peverwheepeverwhee
authored
Update rrtmgp lw_rte interface to match new RRTMGP external (ESCOMP#293)
Originator(s): peverwhee Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number): Updates RRTMGP LW RTE interface for updated RRTMGP external addresses ESCOMP/CAM#1357 List all namelist files that were added or changed: N/A List all files eliminated and why: N/A List all files added and what they do: N/A List all existing files that have been modified, and describe the changes: (Helpful git command: `git diff --name-status development...<your_branch_name>`) M schemes/rrtmgp/rrtmgp_lw_main.F90 - remove top_at_1 variable no longer needed by rte_lw interface List all automated tests that failed, as well as an explanation for why they weren't fixed: n/a Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc? no If yes to the above question, describe how this code was validated with the new/modified features:
1 parent 3dec42d commit b402de4

1 file changed

Lines changed: 2 additions & 15 deletions

File tree

‎schemes/rrtmgp/rrtmgp_lw_main.F90‎

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ module rrtmgp_lw_main
1414
!!
1515
subroutine rrtmgp_lw_main_run(doLWrad, doLWclrsky, doGP_lwscat, use_LW_jacobian, use_LW_optimal_angles, &
1616
nGauss_angles, nCol, iter_num, rrtmgp_phys_blksz, lw_optical_props_clrsky, &
17-
lw_optical_props_clouds, top_at_1, sources, sfc_emiss_byband, lw_gas_props, &
18-
aerlw, fluxlwUP_jac, lw_Ds, flux_clrsky, flux_allsky, errmsg, errflg)
17+
lw_optical_props_clouds, sources, sfc_emiss_byband, lw_gas_props, aerlw, &
18+
fluxlwUP_jac, lw_Ds, flux_clrsky, flux_allsky, errmsg, errflg)
1919
use machine, only: kind_phys
2020
use mo_rte_lw, only: rte_lw
2121
use ccpp_fluxes_byband, only: ty_fluxes_byband_ccpp
@@ -32,7 +32,6 @@ subroutine rrtmgp_lw_main_run(doLWrad, doLWclrsky, doGP_lwscat, use_LW_jacobian,
3232
logical, intent(in) :: doGP_lwscat !< Flag to include scattering in clouds
3333
logical, intent(in) :: use_LW_jacobian !< Flag to compute Jacobian
3434
logical, intent(in) :: use_LW_optimal_angles !< Flag to compute and use optimal angles
35-
logical, intent(in) :: top_at_1 !< Flag for vertical ordering convention
3635

3736
integer, target, intent(in) :: nGauss_angles !< Number of gaussian quadrature angles used
3837
integer, intent(in) :: nCol !< Number of horizontal points
@@ -93,7 +92,6 @@ subroutine rrtmgp_lw_main_run(doLWrad, doLWclrsky, doGP_lwscat, use_LW_jacobian,
9392
if (nGauss_angles > 1) then
9493
errmsg = rte_lw( &
9594
lw_optical_props_clrsky%optical_props, & ! IN - optical-properties
96-
top_at_1, & ! IN - vertical ordering flag
9795
sources%sources, & ! IN - source function
9896
sfc_emiss_byband, & ! IN - surface emissivity in each LW band
9997
flux_clrsky%fluxes, & ! OUT - Fluxes
@@ -102,7 +100,6 @@ subroutine rrtmgp_lw_main_run(doLWrad, doLWclrsky, doGP_lwscat, use_LW_jacobian,
102100
else
103101
errmsg = rte_lw( &
104102
lw_optical_props_clrsky%optical_props, & ! IN - optical-properties
105-
top_at_1, & ! IN - vertical ordering flag
106103
sources%sources, & ! IN - source function
107104
sfc_emiss_byband, & ! IN - surface emissivity in each LW band
108105
flux_clrsky%fluxes, & ! OUT - Fluxes
@@ -112,15 +109,13 @@ subroutine rrtmgp_lw_main_run(doLWrad, doLWclrsky, doGP_lwscat, use_LW_jacobian,
112109
if (nGauss_angles > 1) then
113110
errmsg = rte_lw( &
114111
lw_optical_props_clrsky%optical_props, & ! IN - optical-properties
115-
top_at_1, & ! IN - vertical ordering flag
116112
sources%sources, & ! IN - source function
117113
sfc_emiss_byband, & ! IN - surface emissivity in each LW band
118114
flux_clrsky%fluxes, & ! OUT - Fluxes
119115
n_gauss_angles = nGauss_angles) ! IN - Number of angles in Gaussian quadrature
120116
else
121117
errmsg = rte_lw( &
122118
lw_optical_props_clrsky%optical_props, & ! IN - optical-properties
123-
top_at_1, & ! IN - vertical ordering flag
124119
sources%sources, & ! IN - source function
125120
sfc_emiss_byband, & ! IN - surface emissivity in each LW band
126121
flux_clrsky%fluxes) ! OUT - Fluxes
@@ -161,7 +156,6 @@ subroutine rrtmgp_lw_main_run(doLWrad, doLWclrsky, doGP_lwscat, use_LW_jacobian,
161156
if (nGauss_angles > 1) then
162157
errmsg = rte_lw( &
163158
lw_optical_props_clouds%optical_props, & ! IN - optical-properties
164-
top_at_1, & ! IN - vertical ordering flag
165159
sources%sources, & ! IN - source function
166160
sfc_emiss_byband, & ! IN - surface emissivity in each LW band
167161
flux_allsky%fluxes, & ! OUT - Fluxes
@@ -170,7 +164,6 @@ subroutine rrtmgp_lw_main_run(doLWrad, doLWclrsky, doGP_lwscat, use_LW_jacobian,
170164
else
171165
errmsg = rte_lw( &
172166
lw_optical_props_clouds%optical_props, & ! IN - optical-properties
173-
top_at_1, & ! IN - vertical ordering flag
174167
sources%sources, & ! IN - source function
175168
sfc_emiss_byband, & ! IN - surface emissivity in each LW band
176169
flux_allsky%fluxes, & ! OUT - Fluxes
@@ -180,15 +173,13 @@ subroutine rrtmgp_lw_main_run(doLWrad, doLWclrsky, doGP_lwscat, use_LW_jacobian,
180173
if (nGauss_angles > 1) then
181174
errmsg = rte_lw( &
182175
lw_optical_props_clouds%optical_props, & ! IN - optical-properties
183-
top_at_1, & ! IN - vertical ordering flag
184176
sources%sources, & ! IN - source function
185177
sfc_emiss_byband, & ! IN - surface emissivity in each LW band
186178
flux_allsky%fluxes, & ! OUT - Fluxes
187179
n_gauss_angles = nGauss_angles) ! IN - Number of angles in Gaussian quadrature
188180
else
189181
errmsg = rte_lw( &
190182
lw_optical_props_clouds%optical_props, & ! IN - optical-properties
191-
top_at_1, & ! IN - vertical ordering flag
192183
sources%sources, & ! IN - source function
193184
sfc_emiss_byband, & ! IN - surface emissivity in each LW band
194185
flux_allsky%fluxes) ! OUT - Fluxes
@@ -208,7 +199,6 @@ subroutine rrtmgp_lw_main_run(doLWrad, doLWclrsky, doGP_lwscat, use_LW_jacobian,
208199
if (nGauss_angles > 1) then
209200
errmsg = rte_lw( &
210201
lw_optical_props_clrsky%optical_props, & ! IN - optical-properties
211-
top_at_1, & ! IN - vertical ordering flag
212202
sources%sources, & ! IN - source function
213203
sfc_emiss_byband, & ! IN - surface emissivity in each LW band
214204
flux_allsky%fluxes, & ! OUT - Fluxes
@@ -217,7 +207,6 @@ subroutine rrtmgp_lw_main_run(doLWrad, doLWclrsky, doGP_lwscat, use_LW_jacobian,
217207
else
218208
errmsg = rte_lw( &
219209
lw_optical_props_clrsky%optical_props, & ! IN - optical-properties
220-
top_at_1, & ! IN - vertical ordering flag
221210
sources%sources, & ! IN - source function
222211
sfc_emiss_byband, & ! IN - surface emissivity in each LW band
223212
flux_allsky%fluxes, & ! OUT - Fluxes
@@ -227,15 +216,13 @@ subroutine rrtmgp_lw_main_run(doLWrad, doLWclrsky, doGP_lwscat, use_LW_jacobian,
227216
if (nGauss_angles > 1) then
228217
errmsg = rte_lw( &
229218
lw_optical_props_clrsky%optical_props, & ! IN - optical-properties
230-
top_at_1, & ! IN - vertical ordering flag
231219
sources%sources, & ! IN - source function
232220
sfc_emiss_byband, & ! IN - surface emissivity in each LW band
233221
flux_allsky%fluxes, & ! OUT - Fluxes
234222
n_gauss_angles = nGauss_angles) ! IN - Number of angles in Gaussian quadrature
235223
else
236224
errmsg = rte_lw( &
237225
lw_optical_props_clrsky%optical_props, & ! IN - optical-properties
238-
top_at_1, & ! IN - vertical ordering flag
239226
sources%sources, & ! IN - source function
240227
sfc_emiss_byband, & ! IN - surface emissivity in each LW band
241228
flux_allsky%fluxes) ! OUT - Fluxes

0 commit comments

Comments
 (0)