More review comments addressed

Author: cacraigucar

schemes/pumas/micro_pumas_ccpp_dimensions_post.F90

@@ -1,8 +1,5 @@
 module micro_pumas_ccpp_dimensions_post
 
-  use pumas_kinds,       only: pumas_r8=>kind_r8
-  use ccpp_kinds,        only: kind_phys
-
   implicit none
   private
 
@@ -13,8 +10,8 @@ module micro_pumas_ccpp_dimensions_post
 contains
   !> \section arg_table_micro_pumas_ccpp_dimensions_post_run Argument Table
   !! \htmlinclude micro_pumas_ccpp_dimensions_post_run.html
-  subroutine micro_pumas_ccpp_dimensions_post_run(ncol, micro_ncol, nlev, micro_nlev,                   &
-                   nlevp1, micro_nlevp1, trop_cloud_top_lev, qcsinksum_rate1ord, pumas_qcsinksum_rate1ord, airT_tend,       &
+  subroutine micro_pumas_ccpp_dimensions_post_run(ncol, &
+                   trop_cloud_top_lev, qcsinksum_rate1ord, pumas_qcsinksum_rate1ord, airT_tend,       &
                    pumas_airT_tend, airq_tend, pumas_airq_tend,                                         &
                    cldliq_tend, pumas_cldliq_tend, cldice_tend, pumas_cldice_tend, numliq_tend,         &
                    pumas_numliq_tend, numice_tend, pumas_numice_tend, rainliq_tend, pumas_rainliq_tend, &
@@ -42,18 +39,12 @@ subroutine micro_pumas_ccpp_dimensions_post_run(ncol, micro_ncol, nlev, micro_nl
                    frac_cldliq_tend, pumas_frac_cldliq_tend, rain_evap, pumas_rain_evap,                &
                    errmsg, errcode)
 
+    use pumas_kinds,       only: pumas_r8=>kind_r8
+    use ccpp_kinds,        only: kind_phys
+
     ! horizontal dimension
     integer, intent(in) :: ncol
-    ! microphysics_horizontal_dimension
-    integer, intent(in) :: micro_ncol
     ! vertical layer dimension
-    integer, intent(in) :: nlev
-    ! microphysics vertical layer dimension
-    integer, intent(in) :: micro_nlev
-    ! vertical interface dimension
-    integer, intent(in) :: nlevp1
-    ! microphysics vertical interface dimension
-    integer, intent(in) :: micro_nlevp1
     ! index of the top model level for which cloud physics is applied (1 to nlev)
     integer, intent(in) :: trop_cloud_top_lev
 

schemes/pumas/micro_pumas_ccpp_dimensions_post.meta

@@ -1,6 +1,9 @@
 [ccpp-table-properties]
   name = micro_pumas_ccpp_dimensions_post
   type = scheme
+  dependencies = pumas/pumas_kinds.F90
+  kind_spec = pumas_kinds:pumas_r8=>kind_r8
+
 ########################################################################
 [ccpp-arg-table]
   name = micro_pumas_ccpp_dimensions_post_run
@@ -14,44 +17,6 @@
   dimensions = ()
   type = integer
   intent = in
-[micro_ncol]
-  #Equivalent to "horizontal_loop_extent" unless subcolumns is enabled
-  standard_name = microphysics_horizontal_loop_extent
-  long_name = number of horizontal columns used by microphysics
-  units = count
-  dimensions = ()
-  type = integer
-  intent = in
-[nlev]
-  standard_name = vertical_layer_dimension
-  long_name = vertical layer dimension
-  units = count
-  dimensions = ()
-  type = integer
-  intent = in
-[micro_nlev]
-  #Vertical levels from surface to highest level with tropospheric clouds
-  standard_name = microphysics_vertical_layer_dimension
-  long_name = vertical layer dimension used by microphysics
-  units = count
-  dimensions = ()
-  type = integer
-  intent = in
-[nlevp1]
-  standard_name = vertical_interface_dimension
-  long_name = vertical interface dimension
-  units = count
-  dimensions = ()
-  type = integer
-  intent = in
-[micro_nlevp1]
-  #Vertical interfaces from surface to highest level with tropospheric clouds
-  standard_name = microphysics_vertical_interface_dimension
-  long_name = vertical interface dimension used by microphysics
-  units = count
-  dimensions = ()
-  type = integer
-  intent = in
 [trop_cloud_top_lev]
   standard_name = vertical_layer_index_of_troposphere_cloud_physics_top
   units = index

schemes/pumas/micro_pumas_ccpp_dimensions_pre.meta

@@ -138,7 +138,7 @@
   advected = true
 [pumas_cldliq]
   standard_name = pumas_cloud_liquid_water_mixing_ratio_wrt_moist_air_and_condensed_water
-  long_name = microphysics cloud liquid wrt moist air and condensed water of new state
+  long_name = microphysics cloud mixing ratio liquid wrt moist air and condensed water of new state
   units = kg kg-1
   dimensions = (microphysics_horizontal_loop_extent, microphysics_vertical_layer_dimension)
   type = real