Skip to content

Commit 5d18367

Browse files
committed
[FEATURE] add test connection button to prometheus plugin
Signed-off-by: Adrian Sepiół <adisepko@gmail.com> Signed-off-by: Adrian Sepiół <a.sepiol@sap.com>
1 parent 67e0594 commit 5d18367

2 files changed

Lines changed: 5 additions & 7 deletions

File tree

prometheus/src/plugins/PrometheusDatasourceEditor.tsx

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
import { Box, IconButton, TextField, Typography } from '@mui/material';
1515
import { QueryParamValues } from '@perses-dev/components';
16-
import { HTTPSettingsEditor } from '@perses-dev/plugin-system';
16+
import { HTTPSettingsEditor, OptionsEditorProps } from '@perses-dev/plugin-system';
1717
import MinusIcon from 'mdi-material-ui/Minus';
1818
import PlusIcon from 'mdi-material-ui/Plus';
1919
import { ReactElement, useRef, useState } from 'react';
@@ -27,14 +27,10 @@ interface QueryParamEntry {
2727
value: string;
2828
}
2929

30-
export interface PrometheusDatasourceEditorProps {
31-
value: PrometheusDatasourceSpec;
32-
onChange: (next: PrometheusDatasourceSpec) => void;
33-
isReadonly?: boolean;
34-
}
30+
export type PrometheusDatasourceEditorProps = OptionsEditorProps<PrometheusDatasourceSpec>;
3531

3632
export function PrometheusDatasourceEditor(props: PrometheusDatasourceEditorProps): ReactElement {
37-
const { value, onChange, isReadonly } = props;
33+
const { value, onChange, isReadonly, testConnection } = props;
3834

3935
// Counter for generating unique IDs
4036
const nextIdRef = useRef(0);
@@ -171,6 +167,7 @@ export function PrometheusDatasourceEditor(props: PrometheusDatasourceEditorProp
171167
isReadonly={isReadonly}
172168
initialSpecDirect={initialSpecDirect}
173169
initialSpecProxy={initialSpecProxy}
170+
testConnection={testConnection}
174171
/>
175172
<Typography variant="h5" mt={2} mb={1}>
176173
Query Parameters

prometheus/src/plugins/prometheus-datasource.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,4 +129,5 @@ export const PrometheusDatasource: DatasourcePlugin<PrometheusDatasourceSpec, Pr
129129
getBuiltinVariableDefinitions,
130130
OptionsEditorComponent: PrometheusDatasourceEditor,
131131
createInitialOptions: () => ({ directUrl: '' }),
132+
healthCheckPath: '/api/v1/status/buildinfo',
132133
};

0 commit comments

Comments
 (0)