Merge pull request #5 from thimarsola/test/non-final-class-higher-order-regression

test: cover non-final class branch of the higher-order property crash

Author: MrPunyapal

tests/Type/Fixtures/NonFinalObject.php

@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests\Type\Fixtures;
+
+abstract class NonFinalObject
+{
+    public string $title = '';
+}

tests/Type/data/higher-order-expectations.php

@@ -5,6 +5,7 @@
 namespace HigherOrderExpectations;
 
 use Tests\Type\Fixtures\MagicPropertyObject;
+use Tests\Type\Fixtures\NonFinalObject;
 use Tests\Type\Fixtures\Post;
 
 use function PHPStan\Testing\assertType;
@@ -123,6 +124,24 @@ function testMagicPropertyChainDoesNotCrash(): void
     assertType('Pest\Expectations\HigherOrderExpectation<Pest\Expectation<Tests\Type\Fixtures\MagicPropertyObject>, Tests\Type\Fixtures\MagicPropertyObject>', $result);
 }
 
+function testNonFinalClassMissingPropertyDoesNotCrash(NonFinalObject $object): void
+{
+    $result = expect($object)->name;
+    assertType('Pest\Expectations\HigherOrderExpectation<Pest\Expectation<Tests\Type\Fixtures\NonFinalObject>, mixed>', $result);
+}
+
+function testNonFinalClassMissingPropertyChainDoesNotCrash(NonFinalObject $object): void
+{
+    $result = expect($object)->name->toBe('Nuno');
+    assertType('Pest\Expectations\HigherOrderExpectation<Pest\Expectation<Tests\Type\Fixtures\NonFinalObject>, Tests\Type\Fixtures\NonFinalObject>', $result);
+}
+
+function testNonFinalClassRealPropertyStillResolves(NonFinalObject $object): void
+{
+    $result = expect($object)->title;
+    assertType('Pest\Expectations\HigherOrderExpectation<Pest\Expectation<Tests\Type\Fixtures\NonFinalObject>, string>', $result);
+}
+
 function testUnionWithoutClassPropertyDoesNotCrash(): void
 {
     /** @var array<string, mixed>|object|null $payload */