drivers/: Multiple Drivers Are Registered With World Writable - Part 2

Permissions (Part 2)

Description:

In kernel builds, any unprivileged process running on the NuttX
device can open /dev/efuse and attempt to read/write fuse content.
Reading the fuses may provide valuable information to an attacker
controlling the user process. The write operation, in extreme cases
where the fuse blocks are not locked, may brick the device.

DISCLAIMER: I tried to be strict with the settings, better to relax them
later if it's needed.

This is part of apache#19410

See apache#19410

Compiles ok.

Signed-off-by: Catalin Visinescu <catalin_visinescu@yahoo.com>

Author: catalinv-ncc

arch/xtensa/src/common/espressif/esp_dedic_gpio.c

@@ -684,7 +684,7 @@ struct file *esp_dedic_gpio_new_bundle(
   dedic_gpio_common[cpu].refs++;
 
   register_driver(config->path, &dedic_gpio_ops,
-                  0666, priv);
+                  0600, priv);
   return (struct file *)priv;
 }
 

arch/xtensa/src/common/espressif/esp_nxdiag.c

@@ -313,7 +313,7 @@ static ssize_t esp_nxdiag_read(struct file *filep,
 
 static int esp_nxdiag_register(void)
 {
-  return register_driver("/dev/nxdiag", &g_nxdiagops, 0440, NULL);
+  return register_driver("/dev/nxdiag", &g_nxdiagops, 0400, NULL);
 }
 
 /****************************************************************************

arch/xtensa/src/common/espressif/esp_temperature_sensor.c

@@ -415,7 +415,7 @@ static void esp_temp_sensor_register(struct esp_temp_priv_s *priv)
 {
 #ifndef CONFIG_ESPRESSIF_TEMP_UORB
   register_driver(CONFIG_ESPRESSIF_TEMP_PATH, &g_esp_temp_sensor_fops,
-                  0666, priv);
+                  0600, priv);
 #else
   priv->lower.type = SENSOR_TYPE_TEMPERATURE;
   sensor_register(&priv->lower, CONFIG_ESPRESSIF_TEMP_PATH_DEVNO);

boards/arm/cxd56xx/drivers/sensors/ak09912_scu.c

@@ -556,7 +556,7 @@ int ak09912_scu_register(const char *devpath, int minor,
   /* Register the character driver */
 
   snprintf(path, sizeof(path), "%s%d", devpath, minor);
-  ret = register_driver(path, &g_ak09912fops, 0660, priv);
+  ret = register_driver(path, &g_ak09912fops, 0640, priv);
   if (ret < 0)
     {
       snerr("Failed to register driver: %d\n", ret);

boards/arm/cxd56xx/drivers/sensors/bm1383glv_scu.c

@@ -541,7 +541,7 @@ int bm1383glv_register(const char *devpath, int minor,
   /* Register the character driver */
 
   snprintf(path, sizeof(path), "%s%d", devpath, minor);
-  ret = register_driver(path, &g_bm1383glvfops, 0660, priv);
+  ret = register_driver(path, &g_bm1383glvfops, 0640, priv);
   if (ret < 0)
     {
       snerr("Failed to register driver: %d\n", ret);

boards/arm/cxd56xx/drivers/sensors/bm1422gmv_scu.c

@@ -525,7 +525,7 @@ int bm1422gmv_register(const char *devpath, int minor,
   /* Register the character driver */
 
   snprintf(path, sizeof(path), "%s%d", devpath, minor);
-  ret = register_driver(path, &g_bm1422gmvfops, 0660, priv);
+  ret = register_driver(path, &g_bm1422gmvfops, 0640, priv);
   if (ret < 0)
     {
       snerr("Failed to register driver: %d\n", ret);

boards/arm/samv7/common/src/sam_progmem.c

@@ -79,7 +79,7 @@ static int sam_progmem_register_driver(int minor, struct mtd_dev_s *mtd,
 
   /* Register the MTD driver */
 
-  ret = register_mtddriver(devpath, mtd, 0755, NULL);
+  ret = register_mtddriver(devpath, mtd, 0750, NULL);
   if (ret < 0)
     {
       ferr("ERROR: register_mtddriver %s failed: %d\n", devpath, ret);

boards/arm/stm32l1/stm32ldiscovery/src/stm32_lcd.c

@@ -1584,7 +1584,7 @@ int stm32_slcd_initialize(void)
 
       /* Register the LCD device driver */
 
-      ret = register_driver("/dev/slcd0", &g_slcdops, 0644, &g_slcdstate);
+      ret = register_driver("/dev/slcd0", &g_slcdops, 0640, &g_slcdstate);
       g_slcdstate.initialized = true;
 
       /* Then clear the display */

boards/mips/pic32mx/pic32mx7mmb/src/pic32_touchscreen.c

@@ -1371,7 +1371,7 @@ int pic32mx_tsc_setup(int minor)
   snprintf(devname, sizeof(devname), DEV_FORMAT, minor);
   iinfo("Registering %s\n", devname);
 
-  ret = register_driver(devname, &g_tc_fops, 0660, priv);
+  ret = register_driver(devname, &g_tc_fops, 0640, priv);
   if (ret < 0)
     {
       ierr("ERROR: register_driver() failed: %d\n", ret);

boards/mips/pic32mx/sure-pic32mx/src/pic32mx_lcd1602.c

@@ -1076,7 +1076,7 @@ int up_lcd1602_initialize(void)
 
       /* Register the LCD device driver */
 
-      ret = register_driver("/dev/lcd1602", &g_lcdops, 0644, &g_lcd1602);
+      ret = register_driver("/dev/lcd1602", &g_lcdops, 0640, &g_lcd1602);
       g_lcd1602.initialized = true;
     }