Address lint warnings (#52702)

Summary:
Pull Request resolved: #52702

Quick pass over some of the main files in `jsinspector-modern` now that C++ lint warnings have become more prevalent / auto-fixable.

Changelog: [Internal]

Reviewed By: motiz88

Differential Revision: D78490415

fbshipit-source-id: 32debcf5f217e847d326498709d50f695902bb5c

Author: huntie

packages/react-native/ReactCommon/jsinspector-modern/ExecutionContext.h

@@ -9,7 +9,6 @@
 
 #include "UniqueMonostate.h"
 
-#include <cinttypes>
 #include <optional>
 #include <string>
 #include <unordered_set>
@@ -19,7 +18,7 @@ namespace facebook::react::jsinspector_modern {
 
 struct ExecutionContextDescription {
   int32_t id{};
-  std::string origin{""};
+  std::string origin;
   std::string name{"<anonymous>"};
   std::optional<std::string> uniqueId;
 };

packages/react-native/ReactCommon/jsinspector-modern/HostAgent.cpp

@@ -36,8 +36,8 @@ namespace facebook::react::jsinspector_modern {
 class HostAgent::Impl final {
  public:
   explicit Impl(
-      HostAgent& hostAgent,
-      FrontendChannel frontendChannel,
+      HostAgent& /*hostAgent*/,
+      const FrontendChannel& frontendChannel,
       HostTargetController& targetController,
       HostTargetMetadata hostMetadata,
       SessionState& sessionState,
@@ -126,11 +126,11 @@ class HostAgent::Impl final {
     else if (req.method == "Page.reload") {
       targetController_.getDelegate().onReload({
           .ignoreCache =
-              req.params.isObject() && req.params.count("ignoreCache")
+              req.params.isObject() && (req.params.count("ignoreCache") != 0u)
               ? std::optional(req.params.at("ignoreCache").asBool())
               : std::nullopt,
           .scriptToEvaluateOnLoad = req.params.isObject() &&
-                  req.params.count("scriptToEvaluateOnLoad")
+                  (req.params.count("scriptToEvaluateOnLoad") != 0u)
               ? std::optional(
                     req.params.at("scriptToEvaluateOnLoad").asString())
               : std::nullopt,
@@ -139,7 +139,8 @@ class HostAgent::Impl final {
       shouldSendOKResponse = true;
       isFinishedHandlingRequest = true;
     } else if (req.method == "Overlay.setPausedInDebuggerMessage") {
-      auto message = req.params.isObject() && req.params.count("message")
+      auto message =
+          req.params.isObject() && (req.params.count("message") != 0u)
           ? std::optional(req.params.at("message").asString())
           : std::nullopt;
       if (!isPausedInDebuggerOverlayVisible_ && message.has_value()) {

packages/react-native/ReactCommon/jsinspector-modern/HostTarget.cpp

@@ -45,13 +45,13 @@ class HostTargetSession {
             targetController,
             std::move(hostMetadata),
             state_,
-            executor) {}
+            std::move(executor)) {}
 
   /**
    * Called by CallbackLocalConnection to send a message to this Session's
    * Agent.
    */
-  void operator()(std::string message) {
+  void operator()(const std::string& message) {
     cdp::PreparsedRequest request;
     // Messages may be invalid JSON, or have unexpected types.
     try {
@@ -91,7 +91,7 @@ class HostTargetSession {
    * there's no current instance.
    */
   void setCurrentInstance(InstanceTarget* instance) {
-    if (instance) {
+    if (instance != nullptr) {
       hostAgent_.setCurrentInstanceAgent(
           instance->createAgent(frontendChannel_, state_));
     } else {
@@ -148,7 +148,7 @@ std::shared_ptr<HostTarget> HostTarget::create(
     HostTargetDelegate& delegate,
     VoidExecutor executor) {
   std::shared_ptr<HostTarget> hostTarget{new HostTarget(delegate)};
-  hostTarget->setExecutor(executor);
+  hostTarget->setExecutor(std::move(executor));
   return hostTarget;
 }
 
@@ -166,7 +166,7 @@ std::unique_ptr<ILocalConnection> HostTarget::connect(
   session->setCurrentInstance(currentInstance_.get());
   sessions_.insert(std::weak_ptr(session));
   return std::make_unique<CallbackLocalConnection>(
-      [session](std::string message) { (*session)(message); });
+      [session](const std::string& message) { (*session)(message); });
 }
 
 HostTarget::~HostTarget() {
@@ -228,10 +228,7 @@ void HostTargetController::incrementPauseOverlayCounter() {
 
 bool HostTargetController::decrementPauseOverlayCounter() {
   assert(pauseOverlayCounter_ > 0 && "Pause overlay counter underflow");
-  if (--pauseOverlayCounter_ == 0) {
-    return false;
-  }
-  return true;
+  return --pauseOverlayCounter_ != 0;
 }
 
 namespace {

packages/react-native/ReactCommon/jsinspector-modern/InspectorInterfaces.cpp

@@ -10,8 +10,6 @@
 #include <cassert>
 #include <list>
 #include <mutex>
-#include <tuple>
-#include <unordered_map>
 
 namespace facebook::react::jsinspector_modern {
 
@@ -24,7 +22,7 @@ IRemoteConnection::~IRemoteConnection() {}
 IInspector::~IInspector() {}
 IPageStatusListener::~IPageStatusListener() {}
 
-const folly::dynamic targetCapabilitiesToDynamic(
+folly::dynamic targetCapabilitiesToDynamic(
     const InspectorTargetCapabilities& capabilities) {
   return folly::dynamic::object(
       "nativePageReloads", capabilities.nativePageReloads)(
@@ -56,7 +54,7 @@ class InspectorImpl : public IInspector {
    public:
     Page(
         int id,
-        const std::string& title,
+        const std::string& description,
         const std::string& vm,
         ConnectFunc connectFunc,
         InspectorTargetCapabilities capabilities);
@@ -87,7 +85,7 @@ InspectorImpl::Page::Page(
       description_(description),
       vm_(vm),
       connectFunc_(std::move(connectFunc)),
-      capabilities_(std::move(capabilities)) {}
+      capabilities_(capabilities) {}
 
 InspectorImpl::Page::operator InspectorPageDescription() const {
   return InspectorPageDescription{
@@ -124,7 +122,7 @@ void InspectorImpl::removePage(int pageId) {
   std::scoped_lock lock(mutex_);
 
   if (pages_.erase(pageId) != 0) {
-    for (auto listenerWeak : listeners_) {
+    for (auto& listenerWeak : listeners_) {
       if (auto listener = listenerWeak.lock()) {
         listener->onPageRemoved(pageId);
       }
@@ -138,6 +136,7 @@ std::vector<InspectorPageDescription> InspectorImpl::getPages() const {
   std::vector<InspectorPageDescription> inspectorPages;
   // pages_ is a std::map keyed on an incremental id, so this is insertion
   // ordered.
+  inspectorPages.reserve(pages_.size());
   for (auto& it : pages_) {
     inspectorPages.push_back(InspectorPageDescription(it.second));
   }

packages/react-native/ReactCommon/jsinspector-modern/InspectorInterfaces.h

@@ -39,7 +39,7 @@ struct InspectorTargetCapabilities {
   bool prefersFuseboxFrontend = false;
 };
 
-const folly::dynamic targetCapabilitiesToDynamic(
+folly::dynamic targetCapabilitiesToDynamic(
     const InspectorTargetCapabilities& capabilities);
 
 struct InspectorPageDescription {

packages/react-native/ReactCommon/jsinspector-modern/InstanceAgent.cpp

@@ -16,7 +16,7 @@ InstanceAgent::InstanceAgent(
     FrontendChannel frontendChannel,
     InstanceTarget& target,
     SessionState& sessionState)
-    : frontendChannel_(frontendChannel),
+    : frontendChannel_(std::move(frontendChannel)),
       target_(target),
       sessionState_(sessionState) {
   (void)target_;
@@ -36,7 +36,7 @@ bool InstanceAgent::handleRequest(const cdp::PreparsedRequest& req) {
 
 void InstanceAgent::setCurrentRuntime(RuntimeTarget* runtimeTarget) {
   auto previousRuntimeAgent = std::move(runtimeAgent_);
-  if (runtimeTarget) {
+  if (runtimeTarget != nullptr) {
     runtimeAgent_ = runtimeTarget->createAgent(frontendChannel_, sessionState_);
   } else {
     runtimeAgent_.reset();

packages/react-native/ReactCommon/jsinspector-modern/InstanceTarget.cpp

@@ -18,7 +18,7 @@ std::shared_ptr<InstanceTarget> InstanceTarget::create(
     VoidExecutor executor) {
   std::shared_ptr<InstanceTarget> instanceTarget{
       new InstanceTarget(executionContextManager, delegate)};
-  instanceTarget->setExecutor(executor);
+  instanceTarget->setExecutor(std::move(executor));
   return instanceTarget;
 }
 

packages/react-native/ReactCommon/jsinspector-modern/InstanceTarget.h

@@ -16,9 +16,7 @@
 #include <jsinspector-modern/InspectorInterfaces.h>
 #include <jsinspector-modern/RuntimeAgent.h>
 
-#include <list>
 #include <memory>
-#include <optional>
 
 namespace facebook::react::jsinspector_modern {