fix(ios): extract Image.ios.js props once - #57710
Open
mdjastrzebski wants to merge 2 commits into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
javache
approved these changes
Jul 29, 2026
|
@javache has imported this pull request. If you are a Meta employee, you can view this in D114048967. |
^ Conflicts: ^ packages/react-native/Libraries/Image/Image.ios.js
mdjastrzebski
force-pushed
the
refactor/extract-image-ios-props-once
branch
from
July 29, 2026 13:55
5aeb8c0 to
ae90b30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Two changes to
Image.ios.js(follow up to #57633):1. Extract props once. Per @javache 's review comment, props are now destructured once in the parameter list and written into a single
resolvedPropsobject that is spread intoImageViewNativeComponentonce, modelled onViewand matching
Image.android.js. TheImageAnalyticsTagContext.Consumerrender callback is also replacedwith
use(ImageAnalyticsTagContext).2. Align
aria-*vsaccessibilityStatewith other components.aria-*state props now takepriority per key with fallback to
accessibilityState, matchingView,Text,TextInput,PressableandImage.android.js.Image.ios.jswas the only outlier with buggy behavior where the raw objectaccessibilityStateobject replaced the merged one.Changelog:
[IOS] [FIXED] -
Image:aria-*state props are no longer ignored whenaccessibilityStateis also presentTest Plan:
Unchanged tests pass