From 92c74ea2e29523003d2f9bb90dc40ad8e0da3474 Mon Sep 17 00:00:00 2001
From: Glenn Watson <5834289+glennawatson@users.noreply.github.com>
Date: Mon, 12 Oct 2026 21:55:29 +1100
Subject: [PATCH] fix(build)!: honor consumer implicit usings

- Gate transitive namespace imports on the consuming project setting.
- Match the SDK values true and enable across lean, Reactive and WPF packages.
---
 .../buildTransitive/ReactiveUI.Reactive.props                | 5 ++---
 .../buildTransitive/ReactiveUI.Wpf.Reactive.props            | 5 ++---
 src/ReactiveUI.Wpf/buildTransitive/ReactiveUI.Wpf.props      | 5 ++---
 src/ReactiveUI/buildTransitive/ReactiveUI.props              | 5 ++---
 4 files changed, 8 insertions(+), 12 deletions(-)

diff --git a/src/ReactiveUI.Reactive/buildTransitive/ReactiveUI.Reactive.props b/src/ReactiveUI.Reactive/buildTransitive/ReactiveUI.Reactive.props
index 4546adc163..90689dac1c 100644
--- a/src/ReactiveUI.Reactive/buildTransitive/ReactiveUI.Reactive.props
+++ b/src/ReactiveUI.Reactive/buildTransitive/ReactiveUI.Reactive.props
@@ -1,7 +1,6 @@
 <Project>
-  <!-- The binding engine's namespaces are imported for every consumer, so calls such as WhenAnyValue,
-       ObservableForProperty, Bind and BindCommand, and the view locator, resolve without a using directive. -->
-  <ItemGroup>
+  <!-- Import the binding engine's namespaces when the consumer enables implicit usings. -->
+  <ItemGroup Condition="'$(ImplicitUsings)' == 'true' Or '$(ImplicitUsings)' == 'enable'">
     <Using Include="ReactiveUI.Binding.Reactive" />
     <Using Include="ReactiveUI.Binding.Reactive.ObservableForProperty" />
   </ItemGroup>
diff --git a/src/ReactiveUI.Wpf.Reactive/buildTransitive/ReactiveUI.Wpf.Reactive.props b/src/ReactiveUI.Wpf.Reactive/buildTransitive/ReactiveUI.Wpf.Reactive.props
index 198ae7b87e..ed3a0cb74c 100644
--- a/src/ReactiveUI.Wpf.Reactive/buildTransitive/ReactiveUI.Wpf.Reactive.props
+++ b/src/ReactiveUI.Wpf.Reactive/buildTransitive/ReactiveUI.Wpf.Reactive.props
@@ -1,7 +1,6 @@
 <Project>
-  <!-- The WPF binding types, such as BooleanToVisibilityTypeConverter and BooleanToVisibilityHints, come from
-       ReactiveUI.Binding.Wpf.Reactive, so their namespace is imported for every consumer. -->
-  <ItemGroup>
+  <!-- Import the WPF binding types' namespace when the consumer enables implicit usings. -->
+  <ItemGroup Condition="'$(ImplicitUsings)' == 'true' Or '$(ImplicitUsings)' == 'enable'">
     <Using Include="ReactiveUI.Binding.Reactive.Wpf" />
   </ItemGroup>
 </Project>
diff --git a/src/ReactiveUI.Wpf/buildTransitive/ReactiveUI.Wpf.props b/src/ReactiveUI.Wpf/buildTransitive/ReactiveUI.Wpf.props
index bee5ca0b0e..920f799d7d 100644
--- a/src/ReactiveUI.Wpf/buildTransitive/ReactiveUI.Wpf.props
+++ b/src/ReactiveUI.Wpf/buildTransitive/ReactiveUI.Wpf.props
@@ -1,7 +1,6 @@
 <Project>
-  <!-- The WPF binding types, such as BooleanToVisibilityTypeConverter and BooleanToVisibilityHints, come from
-       ReactiveUI.Binding.Wpf, so their namespace is imported for every consumer. -->
-  <ItemGroup>
+  <!-- Import the WPF binding types' namespace when the consumer enables implicit usings. -->
+  <ItemGroup Condition="'$(ImplicitUsings)' == 'true' Or '$(ImplicitUsings)' == 'enable'">
     <Using Include="ReactiveUI.Binding.Wpf" />
   </ItemGroup>
 </Project>
diff --git a/src/ReactiveUI/buildTransitive/ReactiveUI.props b/src/ReactiveUI/buildTransitive/ReactiveUI.props
index b7f8bcb051..6cf7a25600 100644
--- a/src/ReactiveUI/buildTransitive/ReactiveUI.props
+++ b/src/ReactiveUI/buildTransitive/ReactiveUI.props
@@ -1,7 +1,6 @@
 <Project>
-  <!-- The binding engine's namespaces are imported for every consumer, so calls such as WhenAnyValue,
-       ObservableForProperty, Bind and BindCommand, and the view locator, resolve without a using directive. -->
-  <ItemGroup>
+  <!-- Import the binding engine's namespaces when the consumer enables implicit usings. -->
+  <ItemGroup Condition="'$(ImplicitUsings)' == 'true' Or '$(ImplicitUsings)' == 'enable'">
     <Using Include="ReactiveUI.Binding" />
     <Using Include="ReactiveUI.Binding.ObservableForProperty" />
   </ItemGroup>