From 61036eaccc1d7d543a671312e7da4e41cb710e12 Mon Sep 17 00:00:00 2001 From: Tomas Votruba Date: Wed, 21 Oct 2026 08:25:09 +0200 Subject: [PATCH] Match rename map case-insensitively in IdentifierManipulator --- .../Fixture/different_case_method.php.inc | 29 +++++++++++++++++++ src/NodeAnalyzer/IdentifierManipulator.php | 11 +++++-- 2 files changed, 38 insertions(+), 2 deletions(-) create mode 100644 rules-tests/CodeQuality/Rector/MethodCall/AssertIssetToSpecificMethodRector/Fixture/different_case_method.php.inc diff --git a/rules-tests/CodeQuality/Rector/MethodCall/AssertIssetToSpecificMethodRector/Fixture/different_case_method.php.inc b/rules-tests/CodeQuality/Rector/MethodCall/AssertIssetToSpecificMethodRector/Fixture/different_case_method.php.inc new file mode 100644 index 00000000..9f8cb599 --- /dev/null +++ b/rules-tests/CodeQuality/Rector/MethodCall/AssertIssetToSpecificMethodRector/Fixture/different_case_method.php.inc @@ -0,0 +1,29 @@ +asserttrue(isset($node['value1']), 'message'); + $this->ASSERTFALSE(isset($node['value2'])); + } +} + +?> +----- +assertArrayHasKey('value1', $node, 'message'); + $this->assertArrayNotHasKey('value2', $node); + } +} + +?> diff --git a/src/NodeAnalyzer/IdentifierManipulator.php b/src/NodeAnalyzer/IdentifierManipulator.php index 636e872e..6b368a45 100644 --- a/src/NodeAnalyzer/IdentifierManipulator.php +++ b/src/NodeAnalyzer/IdentifierManipulator.php @@ -37,8 +37,15 @@ public function renameNodeWithMap( return false; } - $node->name = new Identifier($renameMethodMap[$oldNodeMethodName]); - return true; + // method names are case-insensitive in PHP, match the map the same way + foreach ($renameMethodMap as $oldName => $newName) { + if (strcasecmp($oldName, $oldNodeMethodName) === 0) { + $node->name = new Identifier($newName); + return true; + } + } + + return false; } private function resolveOldMethodName(