Improve PHPUnit runnable detection

- Require a base_clause on the name-convention (*Test) patterns: a PHPUnit
  test class always extends TestCase (directly or transitively), so a *Test
  class with no `extends` is not PHPUnit and is no longer tagged phpunit-test
  (it is most likely a test from another framework).
- Disambiguate method-level #[Test] by the imported attribute
  (PHPUnit\Framework\Attributes\Test) via the file's `use`, and by a
  fully-qualified #[\PHPUnit\Framework\Attributes\Test], instead of the class
  name — so it no longer misfires on another framework's method-level #[Test].
  This supersedes zed-extensions#121, which matched any attribute whose last name segment is
  "Test" (and would also tag e.g. #[\Testo\Test] or #[\App\Test] as PHPUnit).

Author: roxblnfk

languages/php/runnables.scm

@@ -1,5 +1,9 @@
 ; Class that follow the naming convention of PHPUnit test classes
 ; and that doesn't have the abstract modifier
+; and extends a base class (PHPUnit test classes always inherit from TestCase,
+; directly or transitively; a *Test class with no `extends` at all is not
+; PHPUnit — most likely a Testo test — so requiring a base_clause avoids
+; tagging those as phpunit-test)
 ; and have a method that follow the naming convention of PHPUnit test methods
 ; and the method is public
 (
@@ -9,6 +13,7 @@
         .
         name: (_) @_name
         (#match? @_name ".*Test$")
+        (base_clause)
         body: (declaration_list
             (method_declaration
                 (visibility_modifier)? @_visibility
@@ -23,6 +28,8 @@
 
 ; Class that follow the naming convention of PHPUnit test classes
 ; and that doesn't have the abstract modifier
+; and extends a base class (see note above — filters out inheritance-less
+; Testo classes)
 ; and have a method that has the @test annotation
 ; and the method is public
 (
@@ -32,6 +39,7 @@
         .
         name: (_) @_name
         (#match? @_name ".*Test$")
+        (base_clause)
         body: (declaration_list
             ((comment) @_comment
                 (#match? @_comment ".*@test\\b.*")
@@ -47,44 +55,85 @@
     (#set! tag phpunit-test)
 )
 
-; Class that follow the naming convention of PHPUnit test classes
-; and that doesn't have the abstract modifier
-; and have a method that has the #[Test] attribute
-; and the method is public
+; Method carrying the #[Test] attribute, disambiguated to PHPUnit via the
+; file's `use` import. Both PHPUnit (PHPUnit\Framework\Attributes\Test) and
+; Testo (Testo\Test) expose a method-level #[Test]; since PHP forbids two
+; imports sharing an alias, the presence of `use PHPUnit\Framework\Attributes\Test`
+; proves the attribute is PHPUnit's. This replaces the old class-name (*Test)
+; gate so that a Testo file's #[Test] methods are no longer tagged phpunit-test.
+; (Trade-off: a PHPUnit file importing the attribute via a group use or writing
+; it fully-qualified won't match here — it still gets class-level buttons.)
+;
+; Form 1: no namespace, or `namespace X;` — `use` and class are siblings.
 (
-    (class_declaration
-        (_)* @_modifier
-        (#not-any-eq? @_modifier "abstract")
-        .
-        name: (_) @_name
-        (#match? @_name ".*Test$")
-        body: (declaration_list
-            (method_declaration
-                (attribute_list
-                    (attribute_group
-                        (attribute (name) @_attribute)
-                    )
-                )
-                (#eq? @_attribute "Test")
-                (visibility_modifier)? @_visibility
-                (#eq? @_visibility "public")
-                name: (_) @run
-                (#not-match? @run "^test.*")
-            )
-        )
+    (program
+        (namespace_use_declaration
+            (namespace_use_clause (qualified_name) @_use))
+        (#eq? @_use "PHPUnit\\Framework\\Attributes\\Test")
+        (class_declaration
+            body: (declaration_list
+                (method_declaration
+                    attributes: (attribute_list
+                        (attribute_group
+                            (attribute (name) @_attribute)))
+                    (#eq? @_attribute "Test")
+                    (visibility_modifier)? @_visibility
+                    (#eq? @_visibility "public")
+                    name: (_) @run
+                    (#not-match? @run "^test.*"))))
+    ) @_phpunit-test
+    (#set! tag phpunit-test)
+)
+
+; Form 2: braced `namespace X { ... }`.
+(
+    (namespace_definition
+        body: (compound_statement
+            (namespace_use_declaration
+                (namespace_use_clause (qualified_name) @_use))
+            (#eq? @_use "PHPUnit\\Framework\\Attributes\\Test")
+            (class_declaration
+                body: (declaration_list
+                    (method_declaration
+                        attributes: (attribute_list
+                            (attribute_group
+                                (attribute (name) @_attribute)))
+                        (#eq? @_attribute "Test")
+                        (visibility_modifier)? @_visibility
+                        (#eq? @_visibility "public")
+                        name: (_) @run
+                        (#not-match? @run "^test.*")))))
     ) @_phpunit-test
     (#set! tag phpunit-test)
 )
 
 ; Class that follow the naming convention of PHPUnit test classes
 ; and that doesn't have the abstract modifier
+; and extends a base class (see note above — filters out inheritance-less
+; Testo classes)
 (
     (class_declaration
         (_)* @_modifier
         (#not-any-eq? @_modifier "abstract")
         .
         name: (_) @run
         (#match? @run ".*Test$")
+        (base_clause)
+    ) @_phpunit-test
+    (#set! tag phpunit-test)
+)
+
+; Method carrying a fully-qualified `#[\PHPUnit\Framework\Attributes\Test]`
+; attribute — self-identifying, so no `use` correlation is needed.
+(
+    (method_declaration
+        attributes: (attribute_list
+            (attribute_group
+                (attribute (qualified_name) @_attribute)))
+        (#eq? @_attribute "\\PHPUnit\\Framework\\Attributes\\Test")
+        (visibility_modifier)? @_visibility
+        (#eq? @_visibility "public")
+        name: (_) @run
     ) @_phpunit-test
     (#set! tag phpunit-test)
 )