From e08ed3860419cc8d4bd974cf9f332614cf61ddae Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dean=20Qui=C3=B1anola?= Date: Wed, 28 Oct 2026 21:10:49 -0700 Subject: [PATCH] fix(cli): state runpod-flash deprecation in past tense The final runpod-flash release ships on the sunset date, so the CLI banner, SDK FutureWarning, and README no longer describe the deprecation as upcoming. The README also notes the repository is archived and read-only. Refs SLS-684 --- README.md | 2 +- src/runpod_flash/sunset.py | 10 +++++----- tests/unit/test_sunset.py | 6 ++++++ 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index f268577d..247fd98e 100644 --- a/README.md +++ b/README.md @@ -1,7 +1,7 @@ # Flash > [!WARNING] -> Flash is moving into the Runpod Python SDK 2.0. `runpod-flash` will be deprecated on **October 29, 2026** and will receive no fixes or updates after that date. See the [migration guide](https://docs.runpod.io/sdk/migrate-from-flash). +> Flash has moved into the Runpod Python SDK 2.0. `runpod-flash` was deprecated on **October 29, 2026** and receives no fixes or updates. This repository is archived and read-only. See the [migration guide](https://docs.runpod.io/sdk/migrate-from-flash). > > The `flash` CLI and the SDK print this notice once per process. Set `RUNPOD_FLASH_SILENCE_DEPRECATION=1` to silence it (for example, in CI). diff --git a/src/runpod_flash/sunset.py b/src/runpod_flash/sunset.py index c27dbc76..7c7b6720 100644 --- a/src/runpod_flash/sunset.py +++ b/src/runpod_flash/sunset.py @@ -1,7 +1,7 @@ """Package-level deprecation notice for runpod-flash. -Flash is moving into the Runpod Python SDK 2.0. This module owns the notice -users see before and after the sunset date, shown once per process through +Flash has moved into the Runpod Python SDK 2.0. This module owns the notice +users see once the package is deprecated, shown once per process through one of two channels: - the ``flash`` CLI prints it to stderr on every invocation (stdout stays @@ -26,9 +26,9 @@ MIGRATION_GUIDE_URL = "https://docs.runpod.io/sdk/migrate-from-flash" SUNSET_MESSAGE = ( - "Flash is moving into the Runpod Python SDK 2.0. runpod-flash will be " - f"deprecated on {SUNSET_DATE} and will receive no fixes or updates after " - f"that date. Migration guide: {MIGRATION_GUIDE_URL}" + "Flash has moved into the Runpod Python SDK 2.0. runpod-flash was " + f"deprecated on {SUNSET_DATE} and receives no fixes or updates. " + f"Migration guide: {MIGRATION_GUIDE_URL}" ) _WORKER_ENV_VARS = ("RUNPOD_ENDPOINT_ID", "RUNPOD_POD_ID") diff --git a/tests/unit/test_sunset.py b/tests/unit/test_sunset.py index 661daaef..ae9e76e4 100644 --- a/tests/unit/test_sunset.py +++ b/tests/unit/test_sunset.py @@ -32,6 +32,12 @@ def test_message_states_date_no_updates_and_migration_guide(self): assert "Runpod Python SDK 2.0" in sunset.SUNSET_MESSAGE assert sunset.MIGRATION_GUIDE_URL in sunset.SUNSET_MESSAGE + def test_message_states_deprecation_in_past_tense(self): + # the final release ships at the sunset date, so the notice must not + # describe the deprecation as upcoming + assert "was deprecated on October 29, 2026" in sunset.SUNSET_MESSAGE + assert "will be" not in sunset.SUNSET_MESSAGE + class TestImportWarning: def test_public_api_access_emits_future_warning(self):