Skip to content

Commit c17953d

Browse files
committed
ci: modernize review workflow to latest standard
Forward secrets via `secrets: inherit`, add a dynamic run-name, and add a workflow_dispatch trigger (with pr_number input) for manual re-runs plus the allowed-tools passthrough. The review job now also runs on workflow_dispatch (guarded off only for pull_request_target and dependabot). Keeps the existing dependency-bump job. Issue: CLDSRV-930
1 parent 45108ee commit c17953d

1 file changed

Lines changed: 25 additions & 23 deletions

File tree

.github/workflows/review.yml

Lines changed: 25 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,31 @@
11
name: Code Review
2+
# yamllint disable rule:line-length
3+
run-name: "Code Review for #${{ github.event.pull_request.number || inputs.pr_number }}${{ github.event.pull_request.title && format(' : {0}', github.event.pull_request.title) }}"
4+
# yamllint enable rule:line-length
25

36
on:
4-
pull_request:
5-
types: [opened, synchronize, labeled, unlabeled]
6-
pull_request_target:
7-
types: [opened, synchronize]
7+
pull_request:
8+
types: [opened, synchronize, labeled, unlabeled]
9+
pull_request_target:
10+
types: [opened, synchronize]
11+
workflow_dispatch:
12+
inputs:
13+
pr_number:
14+
description: Pull Request number to review
15+
required: true
816

917
jobs:
10-
review:
11-
if: github.event_name == 'pull_request' && github.actor != 'dependabot[bot]'
12-
uses: scality/workflows/.github/workflows/claude-code-review.yml@v2
13-
secrets:
14-
GCP_WORKLOAD_IDENTITY_PROVIDER: ${{ secrets.GCP_WORKLOAD_IDENTITY_PROVIDER }}
15-
GCP_SERVICE_ACCOUNT: ${{ secrets.GCP_SERVICE_ACCOUNT }}
16-
ANTHROPIC_VERTEX_PROJECT_ID: ${{ secrets.ANTHROPIC_VERTEX_PROJECT_ID }}
17-
CLOUD_ML_REGION: ${{ secrets.CLOUD_ML_REGION }}
18+
review:
19+
if: github.event_name != 'pull_request_target' && github.actor != 'dependabot[bot]'
20+
uses: scality/workflows/.github/workflows/claude-code-review.yml@v2
21+
with:
22+
allowed-tools: >-
23+
${{ github.event_name == 'workflow_dispatch' && '"Bash(gh api repos/*/contents)"' || '' }}
24+
secrets: inherit
1825

19-
review-dependency-bump:
20-
if: github.event_name == 'pull_request_target' && github.actor == 'dependabot[bot]'
21-
uses: scality/workflows/.github/workflows/claude-code-dependency-review.yml@v2
22-
with:
23-
ACTIONS_APP_ID: ${{ vars.ACTIONS_APP_ID }}
24-
secrets:
25-
GCP_WORKLOAD_IDENTITY_PROVIDER: ${{ secrets.GCP_WORKLOAD_IDENTITY_PROVIDER }}
26-
GCP_SERVICE_ACCOUNT: ${{ secrets.GCP_SERVICE_ACCOUNT }}
27-
ANTHROPIC_VERTEX_PROJECT_ID: ${{ secrets.ANTHROPIC_VERTEX_PROJECT_ID }}
28-
CLOUD_ML_REGION: ${{ secrets.CLOUD_ML_REGION }}
29-
ACTIONS_APP_PRIVATE_KEY: ${{ secrets.ACTIONS_APP_PRIVATE_KEY }}
26+
review-dependency-bump:
27+
if: github.event_name == 'pull_request_target' && github.actor == 'dependabot[bot]'
28+
uses: scality/workflows/.github/workflows/claude-code-dependency-review.yml@v2
29+
with:
30+
ACTIONS_APP_ID: ${{ vars.ACTIONS_APP_ID }}
31+
secrets: inherit

0 commit comments

Comments
 (0)