Skip to content

Commit ce9ac1a

Browse files
committed
test: isolate is_scylla-via-sharding detection from LWT key (review feedback)
1 parent e9f95b6 commit ce9ac1a

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

tests/unit/test_protocol_features.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,14 +57,17 @@ def test_is_scylla_detected_via_tablets(self):
5757
assert pf.sharding_info is None
5858

5959
def test_is_scylla_detected_via_sharding(self):
60-
"""ScyllaDB with full sharding is recognised and sharding_info is populated."""
60+
"""ScyllaDB with full sharding is recognised and sharding_info is populated.
61+
62+
Deliberately omits SCYLLA_LWT_ADD_METADATA_MARK so this test isolates
63+
is_scylla detection via sharding_info, not the LWT extension key.
64+
"""
6165
pf = ProtocolFeatures.parse_from_supported({
6266
'SCYLLA_SHARD': ['3'],
6367
'SCYLLA_NR_SHARDS': ['12'],
6468
'SCYLLA_PARTITIONER': ['org.apache.cassandra.dht.Murmur3Partitioner'],
6569
'SCYLLA_SHARDING_ALGORITHM': ['biased-token-round-robin'],
6670
'SCYLLA_SHARDING_IGNORE_MSB': ['12'],
67-
'SCYLLA_LWT_ADD_METADATA_MARK': ['LWT_OPTIMIZATION_META_BIT_MASK=8'],
6871
})
6972
assert pf.is_scylla is True
7073
assert pf.shard_id == 3

0 commit comments

Comments
 (0)