feat: validate the positional name argument against the project name rules

The positional CLI name argument flowed straight from input.args[0] into the generated package.json name and the init-script rename search key without ever passing through validateProjectName — only the interactive prompt path validated. Run the same validation on the positional argument in getArgs and throw with the validation message on failure, matching the other getArgs errors. Validation runs immediately after argument parsing, before fetching template data, so a network failure can't mask the name error.

Author: beeman

.changeset/validate-positional-name.md

@@ -0,0 +1,5 @@
+---
+'create-solana-dapp': minor
+---
+
+Validate the positional `name` CLI argument with the same rules as the interactive prompt. Previously `npx create-solana-dapp My_App` bypassed validation entirely and produced an invalid npm package name and a degenerate rename search key; it now fails with the validation message.

src/utils/get-args.ts

@@ -14,6 +14,7 @@ import { listTemplates } from './list-templates'
 import { listVersions } from './list-versions'
 import { runVersionCheck } from './run-version-check'
 import { Template } from './template'
+import { validateProjectName } from './validate-project-name'
 import { PackageManager } from './vendor/package-manager'
 
 const minimalTemplateName = 'nextjs-anchor'
@@ -57,6 +58,17 @@ Examples:
   // Get the optional name argument (positional)
   const name = input.args[0]
 
+  // The positional name flows into the generated package.json and the rename search key, so it
+  // must pass the same validation as the interactive prompt. Validate before fetching template
+  // data so a network failure can't mask the name error.
+  if (name) {
+    const nameError = validateProjectName(name)
+    if (nameError) {
+      log.error(nameError)
+      throw new Error(nameError)
+    }
+  }
+
   // Get the options from the command line
   const result = input.opts()
   const verbose = result.verbose ?? false

test/get-args.test.ts

@@ -130,6 +130,30 @@ describe('getArgs', () => {
     expect(args.template).toBe(template)
   })
 
+  it('rejects an invalid positional project name', async () => {
+    const message =
+      'Please enter a valid project name (lowercase letters, numbers, and single dashes, starting with a letter)'
+
+    await expect(
+      getArgs(['node', 'create-solana-dapp', 'My_App', '--template', 'basic', '--skip-version-check'], app),
+    ).rejects.toThrow(message)
+
+    expect(log.error).toHaveBeenCalledWith(message)
+    expect(fetchTemplateData).not.toHaveBeenCalled()
+    expect(getPrompts).not.toHaveBeenCalled()
+  })
+
+  it('rejects a positional project name whose directory already exists', async () => {
+    // The 'test' directory exists in the repo root, which is the cwd when running vitest
+    await expect(
+      getArgs(['node', 'create-solana-dapp', 'test', '--template', 'basic', '--skip-version-check'], app),
+    ).rejects.toThrow('Directory already exists')
+
+    expect(log.error).toHaveBeenCalledWith('Directory already exists')
+    expect(fetchTemplateData).not.toHaveBeenCalled()
+    expect(getPrompts).not.toHaveBeenCalled()
+  })
+
   it('parses positional and registered arguments after a template-defined flag', async () => {
     const args = await getArgs(
       [