fix: raise a clear error for an spdx_id with multiple colons

get_full_element_spdx_id unpacked spdx_id.split(":") into exactly two
values, so an id containing more than one colon raised
"ValueError: too many values to unpack (expected 2)" during
bump_spdx_document. validate_spdx_id already rejects such ids with a
descriptive message, but the bump path can run without validation
(pyspdxtools3 --novalidation, or a direct library call).

Check the split length and raise the same descriptive error instead.

Fixes #901

Signed-off-by: Atishyy27 <sethatishayjain@gmail.com>

Author: Atishyy27

src/spdx_tools/spdx/spdx_element_utils.py

@@ -40,7 +40,14 @@ def get_full_element_spdx_id(
     if ":" not in element.spdx_id:
         return f"{document_namespace}#{element.spdx_id}"
 
-    external_id, local_id = element.spdx_id.split(":")
+    split_id = element.spdx_id.split(":")
+    if len(split_id) > 2:
+        raise ValueError(
+            f"spdx_id must not contain more than one colon in order to separate the external document "
+            f"reference id from the internal SPDX id, but is: {element.spdx_id}"
+        )
+
+    external_id, local_id = split_id
     external_uri = None
     for entry in external_document_refs:
         if entry.document_ref_id == external_id:

tests/spdx3/bump/test_external_element_bump.py

@@ -4,12 +4,15 @@
 
 from unittest import TestCase
 
+import pytest
+
 from spdx_tools.spdx3.bump_from_spdx2.checksum import bump_checksum
 from spdx_tools.spdx3.bump_from_spdx2.spdx_document import bump_spdx_document
 from spdx_tools.spdx3.model import ExternalMap
 from spdx_tools.spdx3.payload import Payload
 from spdx_tools.spdx.model import ExternalDocumentRef
 from spdx_tools.spdx.model.document import Document as Spdx2_Document
+from spdx_tools.spdx.spdx_element_utils import get_full_element_spdx_id
 from tests.spdx.fixtures import (
     checksum_fixture,
     creation_info_fixture,
@@ -53,3 +56,17 @@ def test_bump_external_elements():
     assert f"{external_doc_uri}#SPDXRef-Snippet" in payload.get_full_map()
 
     TestCase().assertCountEqual(spdx_document.imports, expected_imports)
+
+
+def test_bump_external_element_with_malformed_spdx_id():
+    """An spdx_id with more than one colon must raise a clear error instead of
+    crashing with an unpack ValueError from split(":")."""
+    document_namespace = document_fixture().creation_info.document_namespace
+    malformed_id = "DocumentRef-external:SPDXRef-Package:extra"
+
+    with pytest.raises(ValueError, match="must not contain more than one colon"):
+        get_full_element_spdx_id(
+            package_fixture(spdx_id=malformed_id),
+            document_namespace,
+            [ExternalDocumentRef("DocumentRef-external", "https://external-document.uri", checksum_fixture())],
+        )