Skip to content

Commit 0129af4

Browse files
SunPyBotCadair
andauthored
Updates from the package template (#955)
Co-authored-by: Cadair <1391051+Cadair@users.noreply.github.com> Co-authored-by: Stuart Mumford <stuart@cadair.com> Co-authored-by: SunPyBot <sunpybot@users.noreply.github.com>
1 parent df5a75d commit 0129af4

5 files changed

Lines changed: 88 additions & 16 deletions

File tree

.cruft.json

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"template": "https://github.com/sunpy/package-template",
3-
"commit": "4ba8b7c6a6bf4f51f7154978ae8d2f3710ef89e5",
3+
"commit": "2a6434a5c749ecde69d00b937a3fef27ecbad656",
44
"checkout": null,
55
"context": {
66
"cookiecutter": {
@@ -26,15 +26,17 @@
2626
"use_extended_ruff_linting": "y",
2727
"matrix_room_id": "!TWSJXVpyflnZOzmSQz:matrix.org",
2828
"extra_ci_jobs": "cron",
29+
"use_sunpy_pr_template": "y",
2930
"_sphinx_theme": "sunpy",
3031
"_parent_project": "",
3132
"_install_requires": "",
3233
"_copy_without_render": [
3334
"docs/_templates",
34-
"docs/_static"
35+
"docs/_static",
36+
".github/workflows/zizmor.yml"
3537
],
3638
"_template": "https://github.com/sunpy/package-template",
37-
"_commit": "4ba8b7c6a6bf4f51f7154978ae8d2f3710ef89e5"
39+
"_commit": "2a6434a5c749ecde69d00b937a3fef27ecbad656"
3840
}
3941
},
4042
"directory": null

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 49 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
1+
# Thank you for contributing to SunPy
2+
3+
## 🚨 IMPORTANT 🚨
4+
5+
We know that working on code and submitting pull requests takes effort, and we appreciate your time.
6+
Thank you.
7+
8+
[Please be aware that everyone has to follow our code of conduct](https://sunpy.org/coc)
9+
10+
[Furthermore, you might need to check with your work place if you are allowed to contribute code](https://docs.sunpy.org/en/latest/dev_guide/contents/newcomers.html)
11+
12+
- Please try to create an issue _before_ creating a Pull Request.
13+
- Please use the following Git commit message style
14+
- Use the future tense ("Adds feature" not "Added feature")
15+
- Limit the first line to 72 characters or less
16+
- **Do not post the output from Large Language Models or similar generative AI as code or comments on GitHub or any other platform.**
17+
If you use generative AI tools as an aid in developing code or documentation changes, ensure that you fully understand the proposed changes and can explain why they are the correct approach and an improvement to the current state.
18+
See our documentation on fair and appropriate [AI usage](https://docs.sunpy.org/en/latest/dev_guide/contents/ai_usage.html).
19+
20+
We have several automatic features that run when a pull request is open.
21+
They can appear daunting but do not worry about them!
22+
[This a brief explanation of them.](https://docs.sunpy.org/en/latest/dev_guide/contents/pr_review_procedure.html#continuous-integration)
23+
24+
## ↑👆 DELETE above _before_ submitting 👆↑
25+
26+
## PR Description
27+
28+
<!--
29+
Please include a summary of the changes and which issue will be addressed.
30+
Please also include relevant motivation and context.
31+
-->
32+
33+
## AI Assistance Disclosure
34+
35+
<!--
36+
To support transparency and sustainable collaboration, please indicate whether AI-assisted tools were used in preparing this pull request.
37+
Your pull request will not be reviewed until you have completed this checklist.
38+
Removing this checklist may result in your pull request being automatically closed without a review.
39+
For further details see our documentation on the fair and appropriate [usage of AI](https://docs.sunpy.org/en/latest/dev_guide/contents/ai_usage.html).
40+
-->
41+
42+
AI tools were used for:
43+
- [ ] Code generation (e.g., when writing an implementation or fixing a bug)
44+
- [ ] Test/benchmark generation
45+
- [ ] Documentation (including examples)
46+
- [ ] Research and understanding
47+
- [ ] No AI tools were used
48+
49+
> Regardless of AI use, the human contributor remains fully responsible for correctness, design choices, licensing compatibility, and long-term maintainability.

.github/workflows/ci.yml

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,14 @@ permissions: {}
2525
jobs:
2626
core:
2727
uses: OpenAstronomy/github-actions-workflows/.github/workflows/tox.yml@8c8bb6c6c962542921f993d47d26df38dccd50b1 # v3.0.2
28+
permissions:
29+
id-token: write
2830
with:
2931
submodules: false
30-
coverage: codecov
32+
coverage: codecov-oidc
3133
toxdeps: tox-pypi-filter
3234
envs: |
3335
- linux: py313-minimal
34-
secrets:
35-
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
3636
3737
sdist_verify:
3838
runs-on: ubuntu-latest
@@ -51,9 +51,11 @@ jobs:
5151
test:
5252
needs: [core, sdist_verify]
5353
uses: OpenAstronomy/github-actions-workflows/.github/workflows/tox.yml@8c8bb6c6c962542921f993d47d26df38dccd50b1 # v3.0.2
54+
permissions:
55+
id-token: write
5456
with:
5557
submodules: false
56-
coverage: codecov
58+
coverage: codecov-oidc
5759
toxdeps: tox-pypi-filter
5860
posargs: -n auto
5961
envs: |
@@ -62,8 +64,7 @@ jobs:
6264
- macos: py312
6365
- linux: py311-oldestdeps
6466
- linux: asdf_schemas
65-
secrets:
66-
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
67+
coverage: false
6768
6869
docs:
6970
needs: [core]
@@ -93,14 +94,14 @@ jobs:
9394
)
9495
needs: [core]
9596
uses: OpenAstronomy/github-actions-workflows/.github/workflows/tox.yml@8c8bb6c6c962542921f993d47d26df38dccd50b1 # v3.0.2
97+
permissions:
98+
id-token: write
9699
with:
97100
submodules: false
98101
toxdeps: tox-pypi-filter
99-
coverage: codecov
102+
coverage: codecov-oidc
100103
envs: |
101104
- linux: py314-devdeps
102-
secrets:
103-
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
104105
105106
build_dists:
106107
# Build wheels on PRs only when labelled. Releases will only be published if tagged ^v.*

.github/workflows/zizmor.yml

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
name: GitHub Actions Security Analysis with zizmor
2+
3+
on:
4+
push:
5+
branches: ["main"]
6+
pull_request:
7+
branches: ["**"]
8+
9+
permissions: {}
10+
11+
jobs:
12+
zizmor:
13+
runs-on: ubuntu-latest
14+
permissions:
15+
security-events: write
16+
17+
steps:
18+
- name: Checkout repository
19+
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
20+
with:
21+
persist-credentials: false
22+
23+
- name: Run zizmor 🌈
24+
uses: zizmorcore/zizmor-action@3dc1ecc9bcb9e94e9b2c709687979e1298497054 # v0.6.2

.pre-commit-config.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,4 @@
11
repos:
2-
- repo: https://github.com/zizmorcore/zizmor-pre-commit
3-
rev: v1.28.0
4-
hooks:
5-
- id: zizmor
62
# This should be before any formatting hooks like isort
73
- repo: https://github.com/astral-sh/ruff-pre-commit
84
rev: "v0.16.1"

0 commit comments

Comments
 (0)