Skip to content

Commit 2c0d084

Browse files
committed
fix(CI): resolve shellcheck and broken-symlink lint failures
The lint workflow added in #120 surfaced three pre-existing failures. This commit fixes the two shellcheck findings and the broken symlink. - init-guidance.sh: the first sed expression matches the literal text "${CLAUDE_PLUGIN_ROOT}" as it appears in the vendored SKILL.md, so the single quotes are required and SC2016 is a false positive. Disable the check at that call with a comment explaining why. - upload-screenshots.sh: verify_on's retry loop never reads its counter, so SC2034 fired on it. Use the conventional throwaway `_` instead. - .claude/rules/plugin-entity-taxonomy.md: the symlink still pointed at docs/guidance/, which ad6ee13 moved to han-plugin-builder/skills/guidance/references/. That commit rewrote the adjacent .claude/rules/ text references but could not catch a symlink target. Repoint it at the file's current home.
1 parent 94c5b30 commit 2c0d084

3 files changed

Lines changed: 6 additions & 3 deletions

File tree

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
../../docs/guidance/plugin-entity-taxonomy.md
1+
../../han-plugin-builder/skills/guidance/references/plugin-entity-taxonomy.md

han-github/skills/work-items-to-issues/scripts/upload-screenshots.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,8 +132,7 @@ put_file() {
132132
# authenticated viewers, so the issue body is correct.
133133
verify_on() {
134134
local branch="$1" api_path="$2"
135-
local attempt
136-
for attempt in 1 2 3 4 5; do
135+
for _ in 1 2 3 4 5; do
137136
if gh api "$api_path?ref=$branch" --jq .sha >/dev/null 2>&1; then
138137
return 0
139138
fi

han-plugin-builder/skills/guidance/scripts/init-guidance.sh

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,10 @@ RULE=".claude/rules/plugin-building-guidance.md"
5151
rewrite_skill() {
5252
file="$1"
5353
tmp="$(mktemp)"
54+
# SC2016 is disabled deliberately: the first expression matches the literal
55+
# text "${CLAUDE_PLUGIN_ROOT}" as it appears in the vendored SKILL.md, so the
56+
# single quotes are required. Expanding it here would match nothing.
57+
# shellcheck disable=SC2016
5458
sed \
5559
-e 's|${CLAUDE_PLUGIN_ROOT}/skills/guidance/references/|.claude/skills/plugin-guidance/references/|g' \
5660
-e 's|^name: guidance$|name: plugin-guidance|' \

0 commit comments

Comments
 (0)