Repository navigation
Handle bookmarked or shared sign-in URLs - #185
Merged
ThaminduDilshan merged 1 commit intoNov 18, 2026
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
🔀 Cross-SDK feature parity, no ports neededThis pull request is labelled |
8 of 12 tasks
brionmario
previously approved these changes
Nov 18, 2026
ThaminduDilshan
commented
Nov 18, 2026
ThaminduDilshan
force-pushed
the
thamindu-bookmark
branch
2 times, most recently
from
November 18, 2026 10:32
44a0b6f to
4d41171
Compare
Signed-off-by: ThaminduDilshan <35653110+ThaminduDilshan@users.noreply.github.com>
ThaminduDilshan
force-pushed
the
thamindu-bookmark
branch
from
November 18, 2026 11:09
4d41171 to
ee620a5
Compare
thiva-k
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Currently when a sign-in page URL is bookmarked or shared, opening it later ends up on an error. The flow it was opened for is gone, and the page doesn't know which application to send the user back to.
This adds the support to
SignIn, so Gate and any custom sign-in page built on the SDK get it.SignInsends the user straight back to the application.refparam the authorize endpoint adds. Else the server's default return URL is used.Approach
resolveFlowReturnUrlin@thunderid/javascriptresolves the return URL throughGET /flow/meta?type=REF, and falls back todefaultReturnUrl. React and Vue export it along withgetFlowMetaandFlowMetaType.SignInuse it only when the flow can't be started again in place. Embedded apps with an application ID behave as before, and an explicitafterFlowExpiredUrlstill wins.type=REFlookup through its same-origin meta route.Related Issues
Related PRs
Checklist
breaking changelabel added.parity/prs-raisedorparity/prs-not-neededadded.parity/prs-raised, the port links are posted as a reply on the parity check's comment.Security checks