Skip to content

Handle bookmarked or shared sign-in URLs - #185

Merged
ThaminduDilshan merged 1 commit into
thunder-id:mainfrom
ThaminduDilshan:thamindu-bookmark
Nov 18, 2026
Merged

ThaminduDilshan merged 1 commit into
thunder-id:mainfrom
ThaminduDilshan:thamindu-bookmark

Conversation

@ThaminduDilshan

@ThaminduDilshan ThaminduDilshan commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Purpose

Currently when a sign-in page URL is bookmarked or shared, opening it later ends up on an error. The flow it was opened for is gone, and the page doesn't know which application to send the user back to.

This adds the support to SignIn, so Gate and any custom sign-in page built on the SDK get it.

  • When the page has no flow to continue, SignIn sends the user straight back to the application.
  • The application URL comes from the ref param the authorize endpoint adds. Else the server's default return URL is used.
  • A flow that expires while the user is on the page keeps the existing countdown.
  • With nowhere to go back to, the existing error stays.

Approach

  • resolveFlowReturnUrl in @thunderid/javascript resolves the return URL through GET /flow/meta?type=REF, and falls back to defaultReturnUrl. React and Vue export it along with getFlowMeta and FlowMetaType.
  • React, Vue and Nuxt SignIn use it only when the flow can't be started again in place. Embedded apps with an application ID behave as before, and an explicit afterFlowExpiredUrl still wins.
  • In React, an execution left in the tab that the server no longer accepts is handled as no flow.
  • Nuxt passes a type=REF lookup through its same-origin meta route.

Related Issues

Related PRs

Checklist

  • Followed the contribution guidelines.
  • Manual test round performed and verified.
  • Documentation provided. (Add links if there are any)
  • Tests provided. (Add links if there are any)
    • Unit Tests
    • Integration Tests
  • Breaking changes. (Fill if applicable)
    • Breaking changes section filled.
    • breaking change label added.
  • Cross-SDK parity. Exactly one of parity/prs-raised or parity/prs-not-needed added.
    • If parity/prs-raised, the port links are posted as a reply on the parity check's comment.

Note: Parity PRs are not needed. The iOS, Android and Flutter SDKs don't render a sign-in page opened from a URL.

Security checks

  • Followed secure coding standards.
  • Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.

@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

🔀 Cross-SDK feature parity, no ports needed

This pull request is labelled parity/prs-not-needed: nothing here has to ship in the other ThunderID SDKs. If that changes, swap the label for parity/prs-raised.

@ThaminduDilshan ThaminduDilshan added the parity/prs-not-needed Nothing here reaches another SDK label Nov 18, 2026
@ThaminduDilshan ThaminduDilshan changed the title Send the sign-in page back to the application when its URL has no flow Handle bookmarked sign-in URLs in SignIn Nov 18, 2026
@ThaminduDilshan ThaminduDilshan changed the title Handle bookmarked sign-in URLs in SignIn Handle bookmarked sign-in URLs Nov 18, 2026
@ThaminduDilshan ThaminduDilshan changed the title Handle bookmarked sign-in URLs Handle bookmarked or shared sign-in URLs Nov 18, 2026
brionmario
brionmario previously approved these changes Nov 18, 2026
Signed-off-by: ThaminduDilshan <35653110+ThaminduDilshan@users.noreply.github.com>
@ThaminduDilshan
ThaminduDilshan merged commit d6381f9 into thunder-id:main Nov 18, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parity/prs-not-needed Nothing here reaches another SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants