You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[develop] Update ufs-weather-model hash to July 9 version (#1383)
* doc/conf.py - Add https://www.nssl.noaa.gov/ to the ignore check listing due to certificate errors
* doc/ContribGuide/contributing.rst - Update URLs for docs.github.com to address warnings
* Externals.cfg - Update ufs-weather-model hash to 5040b33 (July 9)
* parm/wflow/aqm_prep.yaml - Add exclusive flag for task_nexus_emission
* parm/wflow/coldstart.yaml - Add exclusive falgs for task_make_ics and task_make_lbcs
* ush/aqm-use-cases/config.aqm.FallOzone.yaml - Increase walltime from 1 hour and 20 minutes to 2 hours to allow the use case to run on Orion
* ush/aqm-use-cases/config.aqm.AEROMMA.yaml - Increase walltime from 1 hour and 20 minutes to 2 hours to allow the use case to run on Orion
* ush/config_defaults.yaml - Add exclusive to task_nexus_emission, task_make_ics, and task_make_lbcs
Copy file name to clipboardExpand all lines: doc/ContribGuide/contributing.rst
+3-3Lines changed: 3 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -9,7 +9,7 @@ Fork and PR Overview
9
9
10
10
Thank you to the Unified Workflow (UW) team for allowing us to adapt their Fork and PR Model overview for use in the SRW App. The original can be viewed in the `uwtools` :uw:`documentation <sections/contributor_guide/fork_pr_model.html>`.
11
11
12
-
Contributions to the ``ufs-srweather-app`` project are made via a :github-docs:`Fork<pull-requests/collaborating-with-pull-requests/working-with-forks/about-forks>` and :github-docs:`Pull Request (PR)<pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests>` model. GitHub provides a thorough description of this contribution model in their `Contributing to a project` :github-docs:`Quickstart<get-started/exploring-projects-on-github/contributing-to-a-project>`, but the steps, with respect to ``ufs-srweather-app`` contributions, can be summarized as:
12
+
Contributions to the ``ufs-srweather-app`` project are made via a :github-docs:`Fork<pull-requests/reference/forks>` and :github-docs:`Pull Request (PR)<pull-requests/reference/pull-requests>` model. GitHub provides a thorough description of this contribution model in their `Contributing to a project` :github-docs:`Quickstart<get-started/exploring-projects-on-github/contributing-to-a-project>`, but the steps, with respect to ``ufs-srweather-app`` contributions, can be summarized as:
13
13
14
14
#. :github-docs:`Create an issue <issues/tracking-your-work-with-issues/using-issues/creating-an-issue>` to document proposed changes.
15
15
#. :github-docs:`Fork<get-started/exploring-projects-on-github/contributing-to-a-project#creating-your-own-copy-of-a-project>` the :srw-repo:`ufs-srweather-app repository<>` into your personal GitHub account.
@@ -18,7 +18,7 @@ Contributions to the ``ufs-srweather-app`` project are made via a :github-docs:`
18
18
#. :github-docs:`Make, commit, and push changes<get-started/exploring-projects-on-github/contributing-to-a-project#making-and-pushing-changes>` in your clone / to your fork.
19
19
#. When your work is complete, :github-docs:`create a pull request (PR)<get-started/exploring-projects-on-github/contributing-to-a-project#making-a-pull-request>` to merge your changes.
20
20
21
-
For future contributions, you may delete and then recreate your fork or configure the official ``ufs-srweather-app`` repository as a :github-docs:`remote repository<pull-requests/collaborating-with-pull-requests/working-with-forks/configuring-a-remote-repository-for-a-fork>` on your clone and :github-docs:`sync upstream changes<pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork>` to stay up-to-date with the official repository.
21
+
For future contributions, you may delete and then recreate your fork or configure the official ``ufs-srweather-app`` repository as a :github-docs:`remote repository<pull-requests/how-tos/work-with-forks/configuring-a-remote-repository-for-a-fork>` on your clone and :github-docs:`sync upstream changes<pull-requests/how-tos/work-with-forks/syncing-a-fork>` to stay up-to-date with the official repository.
22
22
23
23
24
24
Development and Testing Process
@@ -179,7 +179,7 @@ All changes to the SRW App ``develop`` branch should be handled via GitHub’s "
179
179
180
180
* Ensure that your PR is targeting the base repository ``ufs-community/ufs-srweather-app`` and an appropriate base branch (usually ``develop``).
181
181
* **Complete PR template.** Your PR will appear pre-populated with a :ref:`template <pr-template>` that you should complete. Provide an informative synopsis of your contribution, then mark appropriate checklist items by placing an "X" between their square brackets. You may tidy up the description by removing boilerplate text and non-selected checklist items. View :ref:`useful PR template guidance <pr-template-guidance>` and information on :ref:`best practices <tips-best-practices>` for completing each section below.
182
-
* **Create draft PR.** Use the pull-down arrow on the green button below the description to initially create a :github-docs:`draft pull request<pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests#draft-pull-requests>`.
182
+
* **Create draft PR.** Use the pull-down arrow on the green button below the description to initially create a :github-docs:`draft pull request<pull-requests/reference/pull-requests>`.
183
183
184
184
* Once your draft PR is open, visit its *Files changed* tab and add comments to any lines of code where you think reviewers will benefit from more explanation. Try to save time by proactively answering questions you suspect reviewers will ask.
0 commit comments