Skip to content

Deprecate boolify bash function #1280

Description

@mkavulich

Description

ush/bash_utils/boolify.sh is an old function for convenience that ensured that "boolean" variables in bash were easy to handle; bash does not natively support boolean variables, so in our case these were comparisons with the string "TRUE" or "FALSE". Since it was hard to enforce a standard format in the early days of the workflow, this function ensured that all standard boolean-type strings (TRUE/FALSE, True/False, T/F, etc.) were handled correctly

However, since uwtools is now used to read in all variables from the config file (#1204), we don't need this "boolify" function anymore since the string representation of booleans in bash will always be the pythonic True or False. Therefore we can deprecate the boolify function and change the string comparisons to those values.

Solution

Remove all calls to boolify() and change the string comparison to True or False appropriately.

Requirements**

Remove all calls to boolify() and change the string comparison to True or False appropriately.

Acceptance Criteria (Definition of Done)

Remove all calls to boolify() and change the string comparison to True or False appropriately.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions