Description
ush/bash_utils/boolify.sh is an old function for convenience that ensured that "boolean" variables in bash were easy to handle; bash does not natively support boolean variables, so in our case these were comparisons with the string "TRUE" or "FALSE". Since it was hard to enforce a standard format in the early days of the workflow, this function ensured that all standard boolean-type strings (TRUE/FALSE, True/False, T/F, etc.) were handled correctly
However, since uwtools is now used to read in all variables from the config file (#1204), we don't need this "boolify" function anymore since the string representation of booleans in bash will always be the pythonic True or False. Therefore we can deprecate the boolify function and change the string comparisons to those values.
Solution
Remove all calls to boolify() and change the string comparison to True or False appropriately.
Requirements**
Remove all calls to boolify() and change the string comparison to True or False appropriately.
Acceptance Criteria (Definition of Done)
Remove all calls to boolify() and change the string comparison to True or False appropriately.
Description
ush/bash_utils/boolify.shis an old function for convenience that ensured that "boolean" variables in bash were easy to handle; bash does not natively support boolean variables, so in our case these were comparisons with the string "TRUE" or "FALSE". Since it was hard to enforce a standard format in the early days of the workflow, this function ensured that all standard boolean-type strings (TRUE/FALSE,True/False,T/F, etc.) were handled correctlyHowever, since uwtools is now used to read in all variables from the config file (#1204), we don't need this "boolify" function anymore since the string representation of booleans in bash will always be the pythonic
TrueorFalse. Therefore we can deprecate theboolifyfunction and change the string comparisons to those values.Solution
Remove all calls to
boolify()and change the string comparison toTrueorFalseappropriately.Requirements**
Remove all calls to
boolify()and change the string comparison toTrueorFalseappropriately.Acceptance Criteria (Definition of Done)
Remove all calls to
boolify()and change the string comparison toTrueorFalseappropriately.