chore: update samesite attribute from 'Lax' to 'None' in response settings - #6546
Merged
Conversation
Contributor
Author
|
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information |
There was a problem hiding this comment.
Pull request overview
This PR updates the mk_file_auth cookie configuration in the login and anonymous chat authentication endpoints by changing the cookie SameSite attribute from Lax to "None" to allow cross-site cookie usage.
Changes:
- Updated
mk_file_authcookiesamesiteattribute to"None"in the user login response. - Updated
mk_file_authcookiesamesiteattribute to"None"in the anonymous chat authentication response.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| apps/users/views/login.py | Changes the mk_file_auth cookie SameSite attribute for admin/login responses. |
| apps/chat/views/chat.py | Changes the mk_file_auth cookie SameSite attribute for anonymous chat authentication responses. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
126
to
129
| secure=secure, | ||
| httponly=True, | ||
| samesite='Lax', | ||
| samesite="None", | ||
| ) |
Comment on lines
58
to
61
| secure=secure, | ||
| httponly=True, | ||
| samesite='Lax', | ||
| samesite="None", | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore: update samesite attribute from 'Lax' to 'None' in response settings