Repository navigation
Conversation
|
If you're new to commit signing, there are different ways to set it up: Sign commits with
|
Replace the Linux uniffi libs with builds from agilebits-inc/sdk-core#509 (release/sdk-python-0.4.x: the same sdk-core 3d49ce29 / core 9fc9cf63 public-beta build that shipped in v0.4.1, plus rustls-webpki 0.103.16 and webpki-root-certs 1.0.10). macOS and Windows libs are unchanged: those platforms verify TLS through the OS. Artifacts: sdk-core build run 39679159453 (head 2394c74b) - uniffi-linux-amd64-public-beta sha256:132b8ca6...0246c - uniffi-linux-arm64-public-beta sha256:a2c029af...cd8d9 - "emSign ECC Root CA - G3": 2 -> 0 occurrences in each .so - rustls-webpki 0.103.9 -> 0.103.16 - op_uniffi_core.py bindings identical to v0.4.1
rishiy15
marked this pull request as ready for review
October 22, 2026 15:06
rr3khan
approved these changes
Oct 22, 2026
AJaccP
approved these changes
Oct 22, 2026
bertrmz
reviewed
Oct 22, 2026
bertrmz
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Patch release that stops the SDK on Linux from trusting the eight eMudhra intermediate CA certificates whose private keys were disclosed on 2026-10-20. Tracking: INFRASEC-1824.
4df1453: replaces only the Linuxlibop_uniffi_core.so(x86_64, aarch64)dc722ad: Release v0.4.2 (version0.4.2, build0040201, release notes)Why only Linux
The SDK's TLS goes through
op-tls→rustls-platform-verifier:webpki-root-certs), whichop-tlsadds on Linux only. The v0.4.1 libs ship rustls-webpki 0.103.9 and a bundle that includesemSign ECC Root CA - G3, so a patched system CA store doesn't help.SecTrust/CertGetCertificateChain). The dylibs and dll contain no bundled roots, so rebuilding them changes nothing. Users there depend on Apple's and Microsoft's distrust updates.Where the libs come from
Built from agilebits-inc/sdk-core#509 (branch
release/sdk-python-0.4.x), which is the same sdk-core commit that built v0.4.1's libs (3d49ce29, core9fc9cf63, public-beta channel, viasdk-core/beta/2026-02-09-3d49ce29/ #210 → #239). The only functional change isCargo.lock: rustls-webpki 0.103.9 → 0.103.16 (rejects chains containing the distrusted intermediate SPKIs) and webpki-root-certs 1.0.5 → 1.0.10 (drops emSign ECC Root CA - G3). This avoids shipping ~8 months of unrelated core changes from sdk-coremainin a security patch.Not built with
publish.yml. It only runs frommain, so it would generate client code frommain's core (85a634af) on top of February libs. It also needs all four platform artifacts, and it overwrites the x86_64.sowith the arm64 one (both download into the same flat directory). The libs were copied by hand from the CI artifacts below.Provenance (for reviewers to re-check)
2394c74b)uniffi-linux-amd64-public-betaartifact digestsha256:132b8ca67bd1e77594ba93c8da8f8ad67dfeec2a11c3843a5a09d09dbcf0246cuniffi-linux-arm64-public-betaartifact digestsha256:a2c029af5400004e039057846ce3931b81a49123e5c96850306d8cb6874cd8d9lib/x86_64/libop_uniffi_core.sosha256d030d05c5dca54f82c6cf8a4c00e82b19734d1ce6f5dfa2e5702c3cd2cd060d7lib/aarch64/libop_uniffi_core.sosha256e5238beee526bfc6cc8a59d136a95ad062a433969c5b4c5af4d74924b533eae3Verification
grep -a -c "emSign ECC Root CA - G3": 2 → 0 in both.so(also 0 inside the built wheels)strings: rustls-webpki 0.103.9 → 0.103.16 in both.somain-based build was ~40% larger)op_uniffi_core.pyfrom #509 byte-identical to the committed one (no API change)test-trustedmatrix on this PR (integration tests load the new.soon ubuntu)release/sdk-python-0.4.xpip install onepassword-sdk==0.4.2on Linux and re-check the G3 grep on the installed.soRelease (after approval)
Following
src/release/README.mdfrom this branch:make build-wheels→make release(signed tagv0.4.2, GitHub release, PyPI upload), then merge this PR tomain. Then post in #technical-writer-review-requests. Whether to publish a security advisory is a call for InfraSec.