Skip to content

fix(hash): mark unaligned reads may_alias in xxhash - #383

Merged
haochengxia merged 1 commit into
developfrom
fix/xxhash
Nov 8, 2026
Merged

haochengxia merged 1 commit into
developfrom
fix/xxhash

Conversation

@haochengxia

Copy link
Copy Markdown
Collaborator

What does this PR do?

On GCC for ARM, the vendored xxHash 0.7.4 reads keys through a packed union. Without may_alias (introduced in xxhash 0.8.4), GCC assumes such a read cannot see a store of another type, which leads to test error.

47% tests passed, 8 tests failed out of 15
The following tests did not run:
         15 - testCLI (Skipped)
The following tests FAILED:
          2 - testSyntheticReader (SEGFAULT)
          5 - testSimulator (SEGFAULT)
          6 - testEvictionAlgo (SEGFAULT)
          7 - testMRC (Timeout)
          8 - testAdmissionAlgo (SEGFAULT)
          9 - testPrefetchAlgo (SEGFAULT)
         11 - testLcpReader (Failed)
         14 - testOracleTrace (Failed)

For a conservative fix, we do not upgrade to xxHash 0.8.4 but add may_alias annotation.

Type of change

  • Bug fix
  • New eviction / admission / prefetch algorithm
  • New trace reader or trace format
  • Performance improvement
  • Documentation
  • Build / CI
  • Other:

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-08T00:12:40.668105Z 606066b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@haochengxia
haochengxia merged commit f02f42e into develop Nov 8, 2026
12 checks passed
@haochengxia
haochengxia deleted the fix/xxhash branch November 8, 2026 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant