Repository navigation
Conversation
Windows 的数据库后端从未接入(backend-capabilities 中 database 为 false, 前端调用的数据库命令没有原生实现),但 .db/.sqlite/.duckdb 文件仍被送进 数据库查看器,功能矩阵也标为 implemented。 - getDatabaseTypeFromPath 遵循同一能力开关,后端不可用时这类文件走普通 二进制/文本路由,打开与会话恢复共用此判断 - 功能矩阵中 Windows 的四项数据库能力改为 missing / not-applicable - README 注明数据库工作台目前仅支持 macOS Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Lithe Review结论: 未发现需要阻塞合并的问题。 Scope Check
Suggestions
Summary路由开关位于共享判断函数中,当前 Verification
|
This was referenced Oct 24, 2026
Owner
Author
|
已合并到 #1470(数据库模块插件化的整体 PR),后续在那里继续推进。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
Windows 的数据库后端一直没有接入:
windows/tauri/src/config/backend-capabilities.ts里database: false,前端调用的 9 个数据库命令都没有原生实现,工具菜单里的"数据库"也是禁用状态。但有三处没跟上这个事实:.db、.sqlite、.sqlite3、.duckdb、.duck文件,仍会进入数据库查看器,之后每个请求都被能力开关拒绝。.db这个扩展名很常见,不是 SQLite 的文件也会被拦截过去。implemented / pending,给出的证据只是前端目录。改动
file-utils.ts):getDatabaseTypeFromPath改为遵循同一个database能力开关。后端不可用时返回null,这类文件走普通的二进制或文本路由(由 Core 的document.classifyText判断)。新打开文件和恢复会话都调用这个函数,两处行为一致。能力开启后,行为与原来相同。workspace-session-restore.test.ts):新增用例,覆盖 5 种数据库扩展名在二进制内容下进入二进制查看器、文本内容的.db进入文本编辑器。已确认这个用例在不改代码时会失败。database-connections、database-crud-export、database-query-history、database-schema的 Windows 状态改为missing / not-applicable,证据指向能力表;database-connections的验证说明补充了 Windows 现状。macOS 无任何改动。Windows 数据库前端代码保留不动,后续按 #1466 的插件方案统一处理。
验证
bun test src/features/file-system/controllers/workspace-session-restore.test.ts:18 passbun run typecheck、bunx vp lint(改动文件):通过./scripts/verify-platform-feature-matrix-change.sh <base> HEAD、./scripts/verify-platform-feature-matrix.sh:通过./.agents/skills/write-stable-tests/scripts/verify-test-stability.sh、./scripts/verify-windows-boundaries.sh:通过.db文件;test-stability-windows.ps1 -Scope Frontend需要在 Windows 上执行,本机是 macOS,没有跑🤖 Generated with Claude Code