Repository navigation
Add A4X Max SGLang N3U KV/RR benchmarking recipes - #291
Closed
alisachen-google wants to merge 1 commit into
Closed
alisachen-google wants to merge 1 commit into
alisachen-google wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces benchmarking recipes and deployment scripts for Nemotron-3-Ultra-550B-A55B-NVFP4 on A4X Max GPUs using NVIDIA Dynamo, supporting both aggregated and disaggregated configurations. The changes include configuration files, deployment and sweep scripts, and testing utilities. Review feedback suggests simplifying redundant variable initialization in deploy.py and improving robustness in sweep.py by using safer dictionary access methods to avoid potential KeyErrors.
Place architecture-specific N3U recipes and deploy/sweep entry points under aggregated-serving/dynamo/sglang/n3u-kv-vs-rr and disaggregated-serving/dynamo/sglang/n3u-kv-vs-rr. Put the shared comparison, prerequisites, dataset replay, and quickstart guide in the disaggregated Dynamo SGLang README. Package the measured 24-GPU agg and 64-GPU D88 configurations, performance curves, and same-concurrency and SLO tables. Share the deployment and sweep helpers, image builds, and validated artifacts from the disagg N3U folder. Keep sweeping focused on router settings, concurrency, and AgentX results. Validation: eight offline tests, both entry points from outside the recipe directory, shell syntax, Python lint, local links, and data provenance hashes. The benchmark logic and measured data are preserved; container builds and GKE execution remain untested. Review fixes folded in: deploy.py builds Kube without a redundant None assignment, and sweep.py reads the worker GPU limit with .get() so a pod without one raises the intended "must request four GPUs" error.
alisachen-google
force-pushed
the
add-a4xmax-dynamo-kv-rr-benchmark
branch
from
October 25, 2026 22:42
1baf8c6 to
5ac67e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Place architecture-specific N3U recipes and deploy/sweep entry points under aggregated-serving/dynamo/sglang/n3u-kv-vs-rr and
disaggregated-serving/dynamo/sglang/n3u-kv-vs-rr. Put the shared comparison, prerequisites, dataset replay, and quickstart guide in the disaggregated Dynamo SGLang README.
Package the measured 24-GPU agg and 64-GPU D88 configurations, performance curves, and same-concurrency and SLO tables. Share the deployment and sweep helpers, image builds, and validated artifacts from the disagg N3U folder. Keep sweeping focused on router settings, concurrency, and AgentX results.
Validation: eight offline tests, both entry points from outside the recipe directory, shell syntax, Python lint, local links, and data provenance hashes. The benchmark logic and measured data are preserved; container builds and GKE execution remain untested.