Repository navigation
Act on the remaining PRISM#2 review items - #13
Merged
Merged
Conversation
Three fixes and one new capability, from @wildsm's review. Branch protection is now provable rather than asserted. The review's open item was right: tests/platform/test_branch_protection_contract.py reads source files, so it shows intent, not the live GitHub setting. configure_branch_protection.py gains --verify, which reads the live protection and diffs it against the policy the script applies, exiting non-zero on any mismatch: python tools/ci/configure_branch_protection.py \ --repo AI-ModCon/PRISM --branch main --verify --review-count 0 Run against both repos, every field matches today. That is checkable by anyone with read access, unlike a screenshot. trainer_grpo.py said "meaned"; it now says "averaged". The NCBI reference is trimmed to https://eutils.ncbi.nlm.nih.gov, which resolves, rather than the /entrez/eutils path, which 404s. docs/models/intern-s2-preview.md carried a claim this review disproved. It said Qwen/Qwen3.5-35B-A3B-Instruct is "gated on Hugging Face" and that its HTTP 401 is a sign-in prompt. It is not: a gated repository serves its model card with HTTP 200 and gates only file downloads -- a known-gated repository returns 200 on the same anonymous request -- so 401 means the repository does not resolve. The rest of the family does (Qwen3.5-9B, -4B, -35B-A3B, -397B-A17B), so the -Instruct suffix looks like the error and Qwen/Qwen3.5-35B-A3B is the nearest checkpoint that exists. The note now says that, with the evidence, and is explicit that the exact model behind those defaults is unconfirmed. The files that cite it are left alone deliberately. They are vendored upstream code kept byte-identical for re-sync; pyproject.toml excludes them from lint and formatting and CONTRIBUTING forbids annotating them, so the correction belongs in our own doc. Not addressed here: the SECURITY.md supported-versions table and the two CHANGELOG promotions are gated on the v0.1.0 tag, which NOTICE blocks until the copyright holder is settled with Argonne tech transfer. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
20 of 31 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Acts on the remaining open items from the PRISM v0.1.0 review (#2).
Branch protection is now provable, not asserted. The review's open item was
right:
tests/platform/test_branch_protection_contract.pyreads source files,so it shows intent rather than the live GitHub setting.
configure_branch_protection.pygains--verify, which reads the liveprotection and diffs it against the policy the script applies, exiting
non-zero on any mismatch:
Run against both repos today, every field matches. Anyone with read access can
reproduce it, and it can go in CI — which a screenshot cannot.
Two text fixes from the review:
trainer_grpo.pysaid "meaned"; the NCBIreference is trimmed to
https://eutils.ncbi.nlm.nih.gov, which resolves,rather than the
/entrez/eutilspath, which 404s.A claim in our own docs was wrong.
docs/models/intern-s2-preview.mdsaidQwen/Qwen3.5-35B-A3B-Instructis "gated on Hugging Face" and that itsHTTP 401is a sign-in prompt. It is not. A gated repository serves its modelcard with
HTTP 200and gates only file downloads — a known-gated repositoryreturns 200 on the same anonymous request — so 401 means the repository does
not resolve. The rest of the family does (
Qwen3.5-9B,-4B,-35B-A3B,-397B-A17B), so the-Instructsuffix looks like the error andQwen/Qwen3.5-35B-A3Bis the nearest checkpoint that exists. The note now saysthat, with the evidence table, and is explicit that the exact model behind
those defaults is unconfirmed.
The files that cite it are deliberately untouched: vendored upstream code kept
byte-identical for re-sync, excluded from lint and formatting in
pyproject.toml, andCONTRIBUTING.mdforbids annotating it.Type of Change
Compatibility
src.*import pathsprismCLI surface--verifyis a new read-only flag on an operator script; no existinginvocation changes behavior.
How Has This Been Tested?
frameworks/2026.1.0.one operator script.
New Dependencies, Data, or Assets
None.
Checklist
--verifyhas no unit test: it only reads a live GitHub endpoint, so a testwould either stub the call it exists to make or require network and a token in
CI. Both exit paths were exercised by hand against the real repositories.
AI/LLM Assistance
Unticked pending a human read.
Additional Context
Not addressed here, and why: the
SECURITY.mdsupported-versions table and thetwo
CHANGELOGpromotions are all gated on the v0.1.0 tag, whichNOTICEblocks until the copyright holder is settled with Argonne tech transfer and the
other contributing institutions. Those are one commit once that question is
answered.