You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Need to update reference files of binaural cases? #175
Current libiamf is using this oar commit
If using latest commit (there are some changes for obr), I find there is some difference from original rendering result.
Do you think, if is is required to update the reference files of binaural cases?
Hi @trsonic
I found there is difference after applying this PR,
and the affected TCs are: test_000812, test_000825, test_000826, test_000912, test_000925, test_000931
Hi @yilun-zhangs , I expect that the difference introduced by that PR will be in the first processed block only. Worth confirming, before regenerating the reference files.
I also submitted a relevant fix to the test harness in this PR.
The specs would allow the initial object position to be non-zero. So the old reference files were produced on a buggy implementation. Seems better to update the test files.
In general, these files can drift over time, so I think we could discuss in the working group how to handle these. Maybe we should have occasional releases for OAR and occasional releases of the test suites.
Activity
trsonic commentedon Aug 20, 2026
Hi @yilun-zhangs , can you pinpoint which OAR commit introduced these differences? And which reference files fail?
yilun-zhangs commentedon Aug 21, 2026
Hi @trsonic
I found there is difference after applying this PR,
and the affected TCs are:
test_000812,test_000825,test_000826,test_000912,test_000925,test_000931trsonic commentedon Aug 21, 2026
Hi @yilun-zhangs , I expect that the difference introduced by that PR will be in the first processed block only. Worth confirming, before regenerating the reference files.
I also submitted a relevant fix to the test harness in this PR.
jwcullen commentedon Aug 21, 2026
@yilun
The specs would allow the initial object position to be non-zero. So the old reference files were produced on a buggy implementation. Seems better to update the test files.
In general, these files can drift over time, so I think we could discuss in the working group how to handle these. Maybe we should have occasional releases for OAR and occasional releases of the test suites.