-
-
Notifications
You must be signed in to change notification settings - Fork 84
Improve Contributor Profile header layout #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -62,3 +62,97 @@ a { color: var(--accent); text-decoration: none; } | |
| .fade-up { | ||
| animation: fadeUp 0.22s ease; | ||
| } | ||
|
|
||
| .contributor-profile-actions .social-share-btn { | ||
| box-sizing: border-box; | ||
| height: 44px; | ||
| padding-top: 0; | ||
| padding-bottom: 0; | ||
| justify-content: center; | ||
| } | ||
|
|
||
| .contributor-profile-export { | ||
| transition: transform 0.2s ease, box-shadow 0.2s ease; | ||
| } | ||
|
|
||
| .contributor-profile-export:hover:not(:disabled) { | ||
| transform: translateY(-1px); | ||
| box-shadow: 0 8px 22px rgba(245,197,24,.25) !important; | ||
| } | ||
|
|
||
| .contributor-profile-back { | ||
| transition: background-color 0.2s ease, border-color 0.2s ease, color 0.2s ease; | ||
| } | ||
|
|
||
| .contributor-profile-back:hover { | ||
| background: var(--surface2) !important; | ||
| border-color: rgba(245, 197, 24, 0.35) !important; | ||
| color: var(--text) !important; | ||
| } | ||
|
|
||
| .contributor-profile-github { | ||
| display: inline-flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| width: 32px; | ||
| height: 32px; | ||
| flex: 0 0 32px; | ||
| align-self: center; | ||
| line-height: 0; | ||
| color: var(--text2); | ||
| transition: color 0.2s ease, transform 0.2s ease; | ||
| } | ||
|
|
||
| .contributor-profile-github:hover { | ||
| color: var(--accent); | ||
| transform: translateY(-1px); | ||
| } | ||
|
|
||
| @media (max-width: 600px) { | ||
| .app-navbar { | ||
| padding-left: 12px !important; | ||
| padding-right: 12px !important; | ||
| gap: 8px !important; | ||
| } | ||
|
|
||
| .app-navbar-links { | ||
| min-width: 0; | ||
| } | ||
|
|
||
| .app-navbar-actions { | ||
| gap: 6px !important; | ||
| } | ||
|
|
||
| .navbar-action-label { | ||
| display: none; | ||
| } | ||
|
|
||
| .navbar-icon-action { | ||
| width: 32px; | ||
| height: 32px; | ||
| padding: 0 !important; | ||
| justify-content: center; | ||
| } | ||
|
|
||
| .contributor-profile-heading > div { | ||
| flex-direction: column; | ||
| align-items: stretch !important; | ||
| gap: 16px; | ||
| } | ||
|
|
||
| .contributor-profile-actions { | ||
| width: 100%; | ||
| flex-direction: column; | ||
| align-items: stretch !important; | ||
| } | ||
|
|
||
| .contributor-profile-actions > div, | ||
| .contributor-profile-actions .social-share-btn, | ||
| .contributor-profile-actions .contributor-profile-export { | ||
| width: 100%; | ||
| } | ||
|
|
||
| .contributor-profile-stats { | ||
| grid-template-columns: repeat(2, minmax(0, 1fr)) !important; | ||
|
Comment on lines
+66
to
+156
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value Use alphabetical declaration order in the new CSS blocks. Several blocks do not follow the Google CSS declaration-order rule. For example, Reorder declarations consistently in the changed blocks. As per path instructions, review CSS against the Google CSS style guide. 🤖 Prompt for AI AgentsSource: Path instructions |
||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
Handle a missing
usernamebefore deriving the profile identity.When
usernameis missing, the effect at Line 153 stops loading but does not stop rendering. Line 333 then callsusername.toLowerCase(). Line 454 also callsusername.charAt(). Both calls throw before the page can show a fallback state.Keep hooks unconditional. Then render a missing-profile state before these identity expressions execute.
Also applies to: 432-496
🤖 Prompt for AI Agents