Repository navigation
fix(raw): include LibRaw error messages within ours - #5573
Merged
Merged
Conversation
There were some kinds of LibRaw failures (particularly involving thumbnail retrieval) where we correctly returned false and gave an error message, but there was an error code from libraw that could give more information and we weren't using it. Add their error message within ours. Signed-off-by: Larry Gritz <lg@larrygritz.com>
jinhgkim
reviewed
Oct 16, 2026
…e and libraw-specific codes. Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Oct 17, 2026
…oundation#5573) There were some kinds of LibRaw failures (particularly involving thumbnail retrieval) where we correctly returned false and gave an error message, but there was an error code from libraw that could give more information and we weren't using it. Add their error message within ours. --------- Signed-off-by: Larry Gritz <lg@larrygritz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were some kinds of LibRaw failures (particularly involving thumbnail retrieval) where we correctly returned false and gave an error message, but there was an error code from libraw that could give more information and we weren't using it. Add their error message within ours.