feat: proot debug toggle - #2563
Conversation
Greptile SummaryAdds a persisted PRoot debugging toggle that propagates through the Cordova terminal bridge and conditionally sets PROOT_VERBOSE=2 for newly launched processes.
Confidence Score: 4/5The persisted setting must be applied to native state at startup before this PR is safe to merge. After an Android process restart, the UI restores prootDebug as enabled while ProcessManager.prootDebug returns to false, causing subsequent PRoot launches to omit the requested verbose logging until the user toggles the setting again. Files Needing Attention: src/settings/terminalSettings.js and the terminal native initialization path Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
UI[Terminal settings toggle] --> Persist[Persist prootDebug]
UI --> FG[Foreground Executor bridge]
UI --> BG[Background Executor bridge]
FG --> Flag[ProcessManager.prootDebug]
BG --> Flag
Flag --> Env[Build process environment]
Env --> PRoot[PRoot with PROOT_VERBOSE=2]
Persist -. app restart does not restore native flag .-> Flag
Reviews (1): Last reviewed commit: "feat: proot debug toggle" | Re-trigger Greptile |
| Executor.setProotDebug(value); | ||
| Executor.BackgroundExecutor.setProotDebug(value); |
There was a problem hiding this comment.
When Android restarts the application process after PRoot Debug has been enabled, settings initialization restores the checkbox without calling these native setters, so ProcessManager.prootDebug remains false and newly launched PRoot processes omit PROOT_VERBOSE=2.
Knowledge Base Used: Settings
No description provided.