Skip to content

fix: restore legacy setCriteria delay defaults #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BaruqueRodrigues wants to merge 1 commit into
base: codex/pr2-legacy-compat
Choose a base branch
from
Open

fix: restore legacy setCriteria delay defaults #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions R/api.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,9 +494,13 @@ adjustIncidence <- function(obj, datas = NULL, method = "none",
}

#' Legacy alert-rule constructor
#' @param rule,values,delays Legacy arguments.
#' @param rule,values Legacy arguments.
#' @param delays Legacy list with turn-on and turn-off delays for yellow, orange,
#' and red criteria.
#' @export
setCriteria <- function(rule = NULL, values = NULL, delays = 3) {
setCriteria <- function(rule = NULL, values = NULL,
delays = list(delayy = c(0, 0), delayo = c(0, 0),
delayr = c(0, 0))) {
.deprecate_api("setCriteria()", "define_alert_rules()")
.define_alert_rules_impl(rule, values, delays)
}
Expand Down
11 changes: 9 additions & 2 deletions man/setCriteria.Rd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 11 additions & 0 deletions tests/testthat/test-alert-rules.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,17 @@ test_that("setCriteria validates inputs and returns the legacy structure", {
expect_equal(lengths(criteria), c(crity = 3L, crito = 3L, critr = 3L))
})

test_that("setCriteria keeps its legacy delay-list default", {
expected_delays <- list(
delayy = c(0, 0),
delayo = c(0, 0),
delayr = c(0, 0)
)

expect_identical(eval(formals(setCriteria)$delays), expected_delays)
expect_identical(formals(define_alert_rules)$delays, 3)
})

test_that("alert rules preserve output structure and delayed levels", {
withr::local_options(list(lifecycle_verbosity = "quiet"))
cases <- read_fixture("cases.csv")
Expand Down
Loading