Skip to content

[PWGCF] Add event-by-event event classifier based on number of uncorrelated seeds - #17363

Merged
wenyaCern merged 2 commits into
AliceO2Group:masterfrom
EmilGorm:master
Aug 6, 2026
Merged

[PWGCF] Add event-by-event event classifier based on number of uncorrelated seeds#17363
wenyaCern merged 2 commits into
AliceO2Group:masterfrom
EmilGorm:master

Conversation

@EmilGorm

@EmilGorm EmilGorm commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot added the pwgcf label Aug 6, 2026
@github-actions github-actions Bot changed the title Add event-by-event event classifier based on number of uncorrelated seeds [PWGCF] Add event-by-event event classifier based on number of uncorrelated seeds Aug 6, 2026
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 2 warnings, 🔕 1 disabled

@EmilGorm
EmilGorm marked this pull request as ready for review August 6, 2026 12:58
@alibuild

alibuild commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for c467858 at 2026-08-06 23:51:

## sw/BUILD/O2Physics-latest/log
2026-08-06T23:29:59.750+0200 [24:139826612013632] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-06T23:29:59.750+0200 [24:139826612013632] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-08-06T23:32:04.872+0200 [24:139826612013632] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv6:%5B::1%5D:8980: Failed to connect to remote host: Connection refused]
2026-08-06T23:29:59.817+0200 [23:140362843269696] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-06T23:29:59.817+0200 [23:140362843269696] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-08-06T23:33:33.823+0200 [23:140362843269696] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv6:%5B::1%5D:8980: Failed to connect to remote host: Connection refused]


## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 14 errors and 0 warnings.'
Found 14 errors and 0 warnings.
++ [[ 14 -gt 0 ]]
++ cat /sw/BUILD/f516ece2f73a27ee1555f775da22699deec5caab/O2Physics-code-check/errors.txt
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:187:5: error: function 'isValid' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:188:5: error: function 'nearYield' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:189:5: error: function 'awayYield' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:190:5: error: function 'nuncSeeds' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:530:10: error: implicit conversion 'const TNamed *' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:534:10: error: implicit conversion 'const TNamed *' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:541:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:551:42: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:556:10: error: no header providing "Long64_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:562:19: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:571:47: error: no header providing "std::size_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:605:5: error: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:606:48: error: no header providing "TObject" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:678:66: error: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 14 -gt 0 ]]
++ exit 1
--

Full log here.

@wenyaCern
wenyaCern merged commit b694d2d into AliceO2Group:master Aug 6, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants