Skip to content

[PWGJE] trackEfficiency.cxx itstpcmatching improvement - #17366

Merged
nzardosh merged 3 commits into
AliceO2Group:masterfrom
aimeric-landou:trackEff_itstpcmatchingImprovement
Aug 6, 2026
Merged

[PWGJE] trackEfficiency.cxx itstpcmatching improvement#17366
nzardosh merged 3 commits into
AliceO2Group:masterfrom
aimeric-landou:trackEff_itstpcmatchingImprovement

Conversation

@aimeric-landou

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 1 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild

alibuild commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for d762302 at 2026-08-06 17:24:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 4 errors and 0 warnings.'
Found 4 errors and 0 warnings.
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/b22e6ea3325833d2464ad84526a65e2e9bedaf8b/O2Physics-code-check/errors.txt
PWGJE/Tasks/trackEfficiency.cxx:47:8: error: constructor does not initialize these fields: pdg [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGJE/Tasks/trackEfficiency.cxx:175:139: error: the parameter 'tracks' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGJE/Tasks/trackEfficiency.cxx:200:9: error: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr,-warnings-as-errors]
PWGJE/Tasks/trackEfficiency.cxx:1485:52: error: no header providing "kPDecay" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 4 -gt 0 ]]
++ exit 1
--

Full log here.

@nzardosh
nzardosh merged commit 1249ae9 into AliceO2Group:master Aug 6, 2026
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants