Deploy main to deploy - #115
Merged
Merged
Conversation
* feat: route a novice's practice match to the hospitality bot matchPractice drew from every enabled persona, so there was no way to give a player finishing the tutorial the opponent built to lose to them. The random pool now excludes the hospitality persona: it is enabled and plays real sessions, so without the clause an ordinary player would occasionally draw an opponent that is not trying. A novice whose hospitality lookup fails falls back to the pool and keeps the mark - a missing tutorial opponent must not be the reason a new player cannot start a match. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix: read the novice mark through the entity, not a scalar query The @query returning Mono<Boolean> failed at runtime against a real database: MappingException: Expected to read Document RowDocument{is_novice=false} into type class java.lang.Boolean but didn't find a PersistentEntity Spring Data R2DBC maps a repository query through the repository's domain type, so a single-column projection into Boolean has no entity to map to. Only running the lobby against Postgres surfaced it; nothing in the test suite covers this path. The column now lives on User, where the mapping already works. A failed lookup is logged rather than swallowed: it fails closed, and a novice who quietly never meets the tutorial opponent would otherwise look like a routing bug. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * feat: read novice status from tutorial progress rather than a flag The mark became a value from 0.5 to 1.0, where 1.0 means the tutorial opponent holds nothing back - the same thing as having finished. Routing asks whether the player is short of that rather than whether a boolean is set. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Version bumps in feature pull requests kept conflicting on the same version line. The monorepo deploy skill now makes one bump commit on main per promotion, then tags and releases it on the deploy merge commit. Closes #111
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes the current main branch to deploy.