Skip to content

[BREAKING][fix] Remove controller-side waiting from metadata fetches - #217

Merged
0oshowero0 merged 2 commits into
Ascend:mainfrom
0oshowero0:fix_controller
Nov 13, 2026
Merged

0oshowero0 merged 2 commits into
Ascend:mainfrom
0oshowero0:fix_controller

Conversation

@0oshowero0

Copy link
Copy Markdown
Collaborator

Motivation

GET_META and NOTIFY_DATA_UPDATE share the controller’s ZMQ request loop. When a fetch waits for samples, it delays the producer notifications that would mark those samples as ready.

Changes

  • Check sample readiness once per fetch and reuse cached sampling results when available.
  • Remove polling_mode from default configs, tutorials, recipes, benchmarks, and E2E fixtures.

Breaking change

With the previous default polling_mode=False, get_meta() and async_get_meta() waited for a batch and raised an error on timeout. They now return an empty BatchMeta immediately when no batch is available.

Callers that relied on waiting should check metadata.size == 0 and retry before calling get_data(). StreamingDataset already handles empty batches and retries. Client-side waiting and automatic retries will be implemented in a follow-up. #212

Remove controller.polling_mode from configs and polling_mode from controller constructor calls. Both are accepted and ignored in this release, emit a FutureWarning when supplied, and will be removed in the next release.

Validation

Compilation, Ruff, and 313 targeted tests passed. The full suite stopped during Ray startup due to local permission restrictions.

Check ready samples once so the request loop can continue processing producer
notifications. Keep sampler cache hits available and return an empty BatchMeta
when no batch is ready.

Warn on legacy polling_mode settings and remove them from examples and fixtures.

Signed-off-by: 0oshowero0 <o0showero0@outlook.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T08:30:25.572335Z 7a2254b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Signed-off-by: 0oshowero0 <o0shower0o@outlook.com>
@0oshowero0
0oshowero0 merged commit 32276bb into Ascend:main Nov 13, 2026
8 checks passed
@0oshowero0
0oshowero0 deleted the fix_controller branch November 13, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant