fix(core): flag 'less <adjective> that' as a typo for 'than' (#3736) - #3888
Draft
hammadmunir959 wants to merge 1 commit into
Draft
fix(core): flag 'less <adjective> that' as a typo for 'than' (#3736)#3888hammadmunir959 wants to merge 1 commit into
hammadmunir959 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #3736
Description
Enhances the
ThatThanlinter inharper-coreto catch false negatives whenthatis used as a typo forthanin multi-word comparative phrases formed asless <adjective> that(e.g. "way less common that mp3" -> "way less common than mp3").Guards against false positives by excluding clause-starting words (
is,was,would,had,it,they,those,users, etc.) followingthat.Demo
N/A (Core linting rule covered by unit tests).
How Has This Been Tested?
Added unit tests in
harper-core/src/linting/that_than.rs(fix_way_less_common_that,fix_less_frequent_that). Verified zero regression against existingThatThantests and full test suite.AI Disclosure
If Your PR Implements or Enhances a Linter
Checklist