Skip to content

Fix storage private endpoint names #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Andy Jordan (andyleejordan) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix storage private endpoint names #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions modules/storage/v1/.tests/main.tests.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,31 @@ module test_required_params '../main.bicep' = {
}
}
}

// Test blob storage with a private endpoint
module test_blob_private_endpoint '../main.bicep' = {
name: 'test_blob_private_endpoint'
params: {
name: 'sttest002'
location: location
subnetId: resourceId('Microsoft.Network/virtualNetworks/subnets', 'vnet-test', 'snet-test')
tags: {
env: 'test'
}
}
}

// Test file storage with a private endpoint
module test_file_private_endpoint '../main.bicep' = {
name: 'test_file_private_endpoint'
params: {
name: 'sttest003'
location: location
storageKind: 'FileStorage'
sku: 'Premium_LRS'
subnetId: resourceId('Microsoft.Network/virtualNetworks/subnets', 'vnet-test', 'snet-test')
tags: {
env: 'test'
}
}
}
4 changes: 2 additions & 2 deletions modules/storage/v1/main.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,9 +396,9 @@ resource managementPolicies 'Microsoft.Storage/storageAccounts/managementPolicie

@sys.description('Create or update a Private Endpoint for the Storage Account.')
module pe '.bicep/pe.bicep' = [for endpoint in endpoints: {
name: 'pend-${storageAccountName}-${endpoint[0]}-001'
name: 'pend-${storageAccountName}-${endpoint}-001'
params: {
name: 'pend-${storageAccountName}-${endpoint[0]}-001'
name: 'pend-${storageAccountName}-${endpoint}-001'
location: location
resourceId: storageAccount.id
groupId: endpoint
Expand Down
Loading