[Yeming Liu (isra-fel)]

Related command
az cloud set --name AzureDelosCloud

Description
Partially addresses #34129 by adding the Delos (Germany) sovereign cloud to the known clouds list (CloudNameEnum.AzureDelosCloud + AZURE_DELOS_CLOUD + HARD_CODED_CLOUD_LIST).

Values are derived from the authoritative Azure Architecture & Design Team sovereign-clouds endpoints table.

Deliberate decisions:

• active_directory_graph_resource_id mirrors the Microsoft Graph host (https://graph.svc.sovcloud.de/) rather than the real (deprecated) Azure AD Graph host. Azure AD Graph is retired and must not be used; this matches the existing Bleu behavior.
• GovSG (Singapore) from Add support for the Delos (Germany) & GovSG (Singapore ) sovereign clouds #34129 is intentionally not included here. Unready.

Testing Guide

az cloud list --output table            # AzureDelosCloud is listed
az cloud set --name AzureDelosCloud
az cloud show --name AzureDelosCloud

Unit tests: python -m pytest src/azure-cli-core/azure/cli/core/tests/test_cloud.py -> 14 passed, 1 skipped.

History Notes
[Cloud] az cloud set: Add AzureDelosCloud (Germany sovereign cloud) to the known clouds list

---

This checklist is used to make sure that common guidelines for a pull request are followed.

• The PR title and description has followed the guideline in Submitting Pull Requests.
• I adhere to the Command Guidelines.
• I adhere to the Error Handling Guidelines.

[Copilot]

🟡 Changes recommended

The established cloud command scenario tests need canonical and lowercase Delos cases.

1 open finding

• Add AzureDelosCloud cases to cloud command scenario tests · New

What changed in this PR

Adds Germany’s Delos sovereign cloud to Azure CLI’s built-in cloud definitions.

Changes:

• Adds AzureDelosCloud and its endpoints/suffixes.
• Registers Delos in the hard-coded cloud list.
• Adds a release-history entry.

File	Description
src/​azure-cli-core/​HISTORY.rst	Records Delos cloud support.
src/​azure-cli-core/​azure/​cli/​core/​cloud.py	Defines and registers Delos cloud metadata.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Yong Zhang (yonzhan)]

Add AzureDelosCloud (Germany sovereign cloud) to the known clouds list

[microsoft-github-policy-service]

🔔 Routing this PR to @Azure/act-codegen-extensibility-squad.

[x-engineering-agent]

X Engineering Agent Report

Review — Comments

Yeming Liu (@isra-fel)

Review: Delos regression coverage needed

Upstream CI passed (51/51), but Delos registration, selection and endpoint/output regression coverage is not verified. No production defect was established. The Delos part of #34129 is implemented; GovSG is explicitly deferred.

Confirmed coverage gap

P2: the new registered cloud is not independently asserted. src/azure-cli-core/azure/cli/core/cloud.py:523-553 adds Delos endpoints/suffixes and registration. Existing core tests (src/azure-cli-core/azure/cli/core/tests/test_cloud.py:170-175) iterate the implementation's own KNOWN_CLOUDS: removing Delos also removes it from the test loop without failure. Command selection tests (src/azure-cli/azure/cli/command_modules/cloud/tests/latest/test_cloud.py:25-63) exercise existing clouds but have no Delos case. The core metadata-comparison test at lines 232-246 is skipped.

Focused correction before merge: Add independent Delos membership and canonical/lowercase selection assertions, checking name, isActive, and expected endpoint/suffix output. Verify removing registration makes those assertions fail. Owner reruns: azdev test --src-file src/azure-cli-core/azure/cli/core/tests/test_cloud.py and azdev test cloud -a "-n 1".

Test validation

• Agent live test: Not run; this is a review-only PR. Check author-provided test evidence and upstream CI separately.
• Regression coverage: Not applicable to the changed files.

The formatted coverage result reflects the tool's exclusion of core production files, not verified Delos coverage. The author reports 14 passed / 1 skipped core tests; that evidence and upstream CI do not prove the new sovereign endpoints or cloud-selection output.

No test or recording changed. src/azure-cli/azure/cli/command_modules/cloud/tests/latest/recordings/test_cloud_scenario.yaml:14-17 records public-cloud metadata, not Delos. Local hard-coded selection checks need no fabricated HTTP cassette; any added discovery/request-response scenario must update its own recording and rerun playback. Sovereign endpoint/audience validity and service availability require core/cloud owner confirmation. The closing risk includes the reviewed core production file and sovereign behavior, which the automatic module-scope classifier omitted.

Risk assessment

31/100 · Medium · High confidence

The Medium rating is driven by sovereign-cloud behavior, no changed regression test.

• Change scope: 1 changed file, 33 changed lines (+32 / -1), including 1 production file.
• Affected components: core/cloud
• Risk drivers: sovereign-cloud behavior (+18); no changed regression test (+10)
• Regression evidence: No changed regression test was detected for the production changes, increasing risk.
• Confidence: High because changed-line patches were available for every production file.
• Required review: Owning-squad review is required for core/cloud before merge.

Posted by x-engineering-agent (Reviewer)

[microsoft-github-policy-service]

🔔 Routing this PR to @Azure/act-codegen-extensibility-squad.