{Compute} `az vm create/update`: Support FlexProfile with `--preferred-size` by william051200 · Pull Request #34231 · Azure/azure-cli

William (william051200) · 2026-10-16T00:59:55Z

🤖 PR Validation — ⚠️ Review suggested

Breaking Changes	Tests
⚠️ None	️✔️ 130/130

⚠️AzureCLI-BreakingChangeTest

⚠️vm

rule cmd_name rule_message suggest_message

⚠️ 1006 - ParaAdd vm create cmd vm create added parameter preferred_size

⚠️ 1009 - ParaPropRemove vm create cmd vm create update parameter size: removed property default=Standard_D2s_v5

⚠️ 1006 - ParaAdd vm update cmd vm update added parameter preferred_size

Related command

az vm create/ show/ update/ list

Description

Resolve #34222

aaz Azure/aaz#1128

Testing Guide

Prepared 2 test cases test_vm_flex_profile_create_and_update and test_vm_flex_profile_opt_in_opt_out
Currently not able to run due to insufficient permission, providing private preview package for service team to test it out

History Notes

[Compute] az vm create/update: Support FlexProfile with --preferred-size

This checklist is used to make sure that common guidelines for a pull request are followed.

The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.

Copilot

🟡 Changes recommended

The inherited size default blocks VM creation when only --preferred-size is supplied.

1 open finding

Set VM create size default to None to allow preferred-size · New

What changed in this PR

Adds FlexProfile support to VM commands, allowing preferred sizes and preserving FlexProfile during ordinary updates.

Changes:

Adds --preferred-size validation and create/update handling.
Extends generated VM schemas to retain and return FlexProfile.
Adds usage examples and live scenarios.

File	Description
src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_vm_commands.py	Adds FlexProfile lifecycle scenarios.
src/azure-cli/azure/cli/command_modules/vm/operations/vm.py	Converts FlexProfile field names.
src/azure-cli/azure/cli/command_modules/vm/custom.py	Handles preferred-size creation and updates.
src/azure-cli/azure/cli/command_modules/vm/aaz/latest/vm/_wait.py	Recognizes FlexProfile responses.
src/azure-cli/azure/cli/command_modules/vm/aaz/latest/vm/_update.py	Preserves and updates FlexProfile.
src/azure-cli/azure/cli/command_modules/vm/aaz/latest/vm/_show.py	Exposes FlexProfile in VM details.
src/azure-cli/azure/cli/command_modules/vm/aaz/latest/vm/_list.py	Exposes FlexProfile in resource-group listings.
src/azure-cli/azure/cli/command_modules/vm/aaz/latest/vm/_list_all.py	Exposes FlexProfile in subscription listings.
src/azure-cli/azure/cli/command_modules/vm/aaz/latest/vm/_create.py	Adds generated FlexProfile schemas.
src/azure-cli/azure/cli/command_modules/vm/_validators.py	Validates size options and uses preferred sizes.
src/azure-cli/azure/cli/command_modules/vm/_template_builder.py	Emits FlexProfile without a fixed VM size.
src/azure-cli/azure/cli/command_modules/vm/_params.py	Registers `--preferred-size`.
src/azure-cli/azure/cli/command_modules/vm/_help.py	Documents creation, opt-in, and opt-out.

🧠 Review effort: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.


    for scope in ['vm create', 'vm update']:
        with self.argument_context(scope) as c:
+            c.argument('preferred_size', completer=get_vm_size_completion_list, is_preview=True, help='Preferred VM size for Flow VMs. Azure may deploy a compatible alternative size. Cannot be used with --size.')


x-engineering-agent · 2026-10-16T01:53:10Z

X Engineering Agent Report

Review — Comments

William (@william051200)

Upstream CI passed, but regression coverage for #34222's FlexProfile service scenarios is not verified. The new read/write mappings address the reported GET-to-PUT field loss in the inspected paths; successful feature-enabled round-trips and generated-source reproducibility remain unverified.

Upstream CI

53 upstream checks completed successfully for 4f36410758b2aad24be14cb6bb9d76f9bf779c94. This does not establish execution of the two new live-only scenarios.

Test validation

Agent live test: Not run; this is a review-only PR. Check author-provided test evidence and upstream CI separately.
Regression coverage: For vm: 1 focused test file(s) changed. Scenario coverage is unverified; review the issue's required conditions, test setup, and assertions before approval. No linked issue was found in the PR timeline; inspect the source issue and its required scenario manually.

Required scenario evidence: Both new cases in src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_vm_commands.py are @live_only(), and the author explicitly reports insufficient preview access. No recordings changed. Before merge, obtain service-team execution evidence for VMFlexProfileScenarioTests.test_vm_flex_profile_create_and_update and VMFlexProfileScenarioTests.test_vm_flex_profile_opt_in_opt_out, at this SHA, in a supported region/subscription with Microsoft.Compute/FlexProfileEnabled. These are the focused rerun targets; the Agent did not run them.

The changed template builder omits fixed hardwareProfile.vmSize for preferred-size creation; the generated read/update schemas and conversion layer now carry flexProfile.preferredVMSize. The service must still demonstrate ordinary tag-update preservation, same-deployed-size acceptance, different-size rejection, opt-in without fixed size, opt-out without FlexProfile, and show/list output. Add production-shaped offline GET-to-PUT/template assertions for the urgent preservation path so preview access is not its only regression gate. Existing recordings without the new response field cannot prove it survives serialization; resize and other full-PUT paths need owner confirmation too.

Repository policy findings

Release artifact validator (blocking) — src/azure-cli/azure/cli/command_modules/vm/_help.py:1087: Customer-visible Azure CLI behavior is not marked for generated release notes in the PR metadata.
Remediation: Start the PR title with [Component] and describe the customer-facing change there. For multiple or overriding notes, use the PR description's History Notes section.
Verify: Run the PR title/content check and confirm the metadata is accepted for automatic history generation.

Release-finding reconciliation: The description already contains [VM] az vm create/update: Support FlexProfile with --preferred-size`` under History Notes, and upstream title/content CI is green. The inspected detector only tests whether the title starts with [; it does not inspect the description's History Notes. Its missing-note conclusion is therefore not confirmed by the current metadata. No duplicate history entry or direct `HISTORY.rst` edit is requested; confirm the existing note is consumed by generation.

Generated ownership: The six changed vm/aaz/latest/vm files are generated surfaces. The description links Azure/aaz#1128, but this review has not verified regeneration from that source revision. The VM owner should confirm reproducibility rather than hand-edit generated output.

Risk assessment — 59/100 · High · High confidence

The High rating is driven by security-sensitive behavior, public CLI behavior, generated output.

Change scope: 13 changed files, 278 changed lines (+262 / -16), including 12 production files.
Affected components: vm
Risk drivers: security-sensitive behavior (+28); public CLI behavior (+18); generated output (+12)
Regression evidence: Changed regression tests are included, reducing risk.
Confidence: High because changed-line patches were available for every production file.
Required review: Owning-squad review is required for vm before merge.

Posted by x-engineering-agent (Reviewer)

Yong Zhang (yonzhan) · 2026-10-16T02:52:57Z

/azp run

azure-pipelines · 2026-10-16T02:53:11Z

Azure Pipelines: Successfully started running 3 pipeline(s).

William (william051200) added 6 commits October 14, 2026 14:32

Export latest aaz 2026-04-01 for vm operations

0ba19af

Add conversion for new param

9086035

Update code

132a5c3

Add test case

8b48991

Update test cases

152b812

Update code

e18003c

Copilot AI balanced review requested due to automatic review settings October 16, 2026 00:59

William (william051200) requested a review from a team as a code owner October 16, 2026 00:59

microsoft-github-policy-service Bot requested a review from Yong Zhang (yonzhan) October 16, 2026 01:00

Copilot started reviewing on behalf of William (william051200) October 16, 2026 01:00

View session

William (william051200) mentioned this pull request Oct 16, 2026

Export new param for vm flex profile Azure/aaz#1128

Open

microsoft-github-policy-service Bot added the Auto-Assign Auto assign by bot label Oct 16, 2026

Copilot AI reviewed Oct 16, 2026

View reviewed changes

x-engineering-agent Bot added this to the November 2026 (2026-11-03) milestone Oct 16, 2026

Update code

4f36410

William (william051200) added the Request X Engineering Agent Ask the agent to triage this issue or review this PR label Oct 16, 2026

x-engineering-agent Bot changed the title ~~{Compute} az vm create/update: Support FlexProfile with --preferred-size~~ {VM} az vm create/update: Support FlexProfile with --preferred-size Oct 16, 2026

William (william051200) changed the title ~~{VM} az vm create/update: Support FlexProfile with --preferred-size~~ {Compute} az vm create/update: Support FlexProfile with --preferred-size Oct 16, 2026

x-engineering-agent Bot changed the title ~~{Compute} az vm create/update: Support FlexProfile with --preferred-size~~ {VM} az vm create/update: Support FlexProfile with --preferred-size Oct 16, 2026

x-engineering-agent Bot added the X Engineering Agent Reviewed Agent reviewed this PR label Oct 16, 2026

William (william051200) changed the title ~~{VM} az vm create/update: Support FlexProfile with --preferred-size~~ {Compute} az vm create/update: Support FlexProfile with --preferred-size Oct 16, 2026

Navigation Menu

Repository navigation

{Compute} `az vm create/update`: Support FlexProfile with `--preferred-size` - #34231

{Compute} `az vm create/update`: Support FlexProfile with `--preferred-size`#34231
William (william051200) wants to merge 7 commits into
Azure:devfrom
william051200:vm-flex-profile

William (william051200) commented Oct 16, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

x-engineering-agent Bot commented Oct 16, 2026 •

edited

Loading

Uh oh!

Yong Zhang (yonzhan) commented Oct 16, 2026

Uh oh!

azure-pipelines Bot commented Oct 16, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rule	cmd_name	rule_message
⚠️ 1006 - ParaAdd	vm create	cmd `vm create` added parameter `preferred_size`
⚠️ 1009 - ParaPropRemove	vm create	cmd `vm create` update parameter `size`: removed property `default=Standard_D2s_v5`
⚠️ 1006 - ParaAdd	vm update	cmd `vm update` added parameter `preferred_size`

Conversation

William (william051200) commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 PR Validation — ⚠️ Review suggested

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

x-engineering-agent Bot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

X Engineering Agent Report

Uh oh!

Yong Zhang (yonzhan) commented Oct 16, 2026

Uh oh!

azure-pipelines Bot commented Oct 16, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

William (william051200) commented Oct 16, 2026 •

edited

Loading

x-engineering-agent Bot commented Oct 16, 2026 •

edited

Loading